linux-kernel - Re: [PATCH] staging: sm750fb: Replace architecture-specific defines with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025032040-yesterday-maturity-2f21@gregkh>
Date: Thu, 20 Mar 2025 07:12:49 -0700
From: Greg KH <gregkh@...uxfoundation.org>
To: Madhur Kumar <madhurkumar004@...il.com>
Cc: sudipm.mukherjee@...il.com, teddy.wang@...iconmotion.com,
	linux-fbdev@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: sm750fb: Replace architecture-specific defines
 with CONFIG_X86

On Sun, Feb 23, 2025 at 01:02:42AM +0530, Madhur Kumar wrote:
> Replace the use of __i386__ and __x86_64__ with CONFIG_X86 to adhere to
> kernel coding guideline, make the code more portable and integrates
> better with the Kconfig system.
> 
> Signed-off-by: Madhur Kumar <madhurkumar004@...il.com>
> ---
>  drivers/staging/sm750fb/ddk750_chip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index 02860d3ec..67a2f6044 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -229,7 +229,7 @@ int ddk750_init_hw(struct initchip_param *p_init_param)
>  		reg |= (VGA_CONFIGURATION_PLL | VGA_CONFIGURATION_MODE);
>  		poke32(VGA_CONFIGURATION, reg);
>  	} else {
> -#if defined(__i386__) || defined(__x86_64__)
> +#ifdef CONFIG_X86
>  		/* set graphic mode via IO method */
>  		outb_p(0x88, 0x3d4);
>  		outb_p(0x06, 0x3d5);
> -- 
> 2.48.1
> 
> 

Does not apply to my tree at all :(