linux-kernel - Re: [RFC PATCH 22/35] libceph, rbd: Convert ceph_osdc_notify() reply to ceph

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3172346.1742481855@warthog.procyon.org.uk>
Date: Thu, 20 Mar 2025 14:44:15 +0000
From: David Howells <dhowells@...hat.com>
To: Viacheslav Dubeyko <Slava.Dubeyko@....com>
Cc: dhowells@...hat.com, Alex Markuze <amarkuze@...hat.com>,
    "slava@...eyko.com" <slava@...eyko.com>,
    "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
    "idryomov@...il.com" <idryomov@...il.com>,
    "jlayton@...nel.org" <jlayton@...nel.org>,
    "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
    "ceph-devel@...r.kernel.org" <ceph-devel@...r.kernel.org>,
    "dongsheng.yang@...ystack.cn" <dongsheng.yang@...ystack.cn>,
    "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 22/35] libceph, rbd: Convert ceph_osdc_notify() reply to ceph_databuf

Viacheslav Dubeyko <Slava.Dubeyko@....com> wrote:

> >  		} else if (!completion_done(&lreq->notify_finish_wait)) {
> > -			struct ceph_msg_data *data =
> > -			    msg->num_data_items ? &msg->data[0] : NULL;
> > -
> > -			if (data) {
> > -				if (lreq->preply_pages) {
> > -					WARN_ON(data->type !=
> > -							CEPH_MSG_DATA_PAGES);
> > -					*lreq->preply_pages = data->pages;
> > -					*lreq->preply_len = data->length;
> > -					data->own_pages = false;
> > -				}
> > +			if (msg->num_data_items && lreq->reply) {
> > +				struct ceph_msg_data *data = &msg->data[0];
> 
> This low-level access slightly worry me. I don't see any real problem
> here. But, maybe, we need to hide this access into some iterator-like
> function? However, it could be not feasible for the scope of this patchset.

Yeah.  This is something that precedes my changes and I think it needs fixing
apart from it.

David