linux-kernel - Re: [PATCH v2 31/57] irqdomain: platform/x86: Switch to irq_domain_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d623f8d9-d772-6418-a420-019472742ffa@linux.intel.com>
Date: Fri, 21 Mar 2025 17:51:45 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
cc: tglx@...utronix.de, maz@...nel.org, LKML <linux-kernel@...r.kernel.org>, 
    Hans de Goede <hdegoede@...hat.com>, 
    Corentin Chary <corentin.chary@...il.com>, 
    "Luke D. Jones" <luke@...nes.dev>, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v2 31/57] irqdomain: platform/x86: Switch to
 irq_domain_create_linear()

On Wed, 19 Mar 2025, Jiri Slaby (SUSE) wrote:

> irq_domain_add_linear() is going away as being obsolete now. Switch to
> the preferred irq_domain_create_linear(). That differs in the first
> parameter: It takes more generic struct fwnode_handle instead of struct
> device_node. Therefore, of_fwnode_handle() is added around the
> parameter.
> 
> Note some of the users can likely use dev->fwnode directly instead of
> indirect of_fwnode_handle(dev->of_node). But dev->fwnode is not
> guaranteed to be set for all, so this has to be investigated on case to
> case basis (by people who can actually test with the HW).
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
> Cc: Hans de Goede <hdegoede@...hat.com>
> Cc: Corentin Chary <corentin.chary@...il.com>
> Cc: "Luke D. Jones" <luke@...nes.dev>
> Cc: "Ilpo Järvinen" <ilpo.jarvinen@...ux.intel.com>
> Cc: platform-driver-x86@...r.kernel.org

I've applied this now to review-ilpo-next, but I had to remove lots of 
unnecessary details from the commit message as here the first arg is NULL.

I'd also prefer to not have long is of Ccs before --- line for changes 
like this (more understandable if it's some problem/fix related 
submission). Wouldn't they work also if Cc: lines are put below --- 
or is it that the tools fail to preserve that at some point?

> ---
>  drivers/platform/x86/asus-tf103c-dock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/asus-tf103c-dock.c b/drivers/platform/x86/asus-tf103c-dock.c
> index ca4670d0dc67..f09a3fc6524a 100644
> --- a/drivers/platform/x86/asus-tf103c-dock.c
> +++ b/drivers/platform/x86/asus-tf103c-dock.c
> @@ -856,7 +856,7 @@ static int tf103c_dock_probe(struct i2c_client *client)
>  	/* 5. Setup irqchip for touchpad IRQ pass-through */
>  	dock->tp_irqchip.name = KBUILD_MODNAME;
>  
> -	dock->tp_irq_domain = irq_domain_add_linear(NULL, 1, &irq_domain_simple_ops, NULL);
> +	dock->tp_irq_domain = irq_domain_create_linear(NULL, 1, &irq_domain_simple_ops, NULL);
>  	if (!dock->tp_irq_domain)
>  		return -ENOMEM;
>  
> 

-- 
 i.