linux-kernel - Re: [PATCH] wifi: mt76: mt7996: remove duplicate check in mt7996_mcu_sta_mld_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z92LRBMxyz4pS7my@lore-desk>
Date: Fri, 21 Mar 2025 16:52:36 +0100
From: Lorenzo Bianconi <lorenzo@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Shayne Chen <shayne.chen@...iatek.com>, Felix Fietkau <nbd@....name>,
	Ryder Lee <ryder.lee@...iatek.com>,
	Sean Wang <sean.wang@...iatek.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Peter Chiu <chui-hao.chiu@...iatek.com>,
	Bo Jiao <Bo.Jiao@...iatek.com>,
	Howard Hsu <howard-yh.hsu@...iatek.com>,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] wifi: mt76: mt7996: remove duplicate check in
 mt7996_mcu_sta_mld_setup_tlv()

> The "msta_link" pointer has two NULL checks.  Delete the second check.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/net/wireless/mediatek/mt76/mt7996/mcu.c | 3 ---
>  1 file changed, 3 deletions(-)
> 

Acked-by: Lorenzo Bianconi <lorenzo@...nel.org>

> diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
> index ddd555942c73..03539e20f5c5 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
> @@ -2242,9 +2242,6 @@ mt7996_mcu_sta_mld_setup_tlv(struct mt7996_dev *dev, struct sk_buff *skb,
>  		if (!link)
>  			continue;
>  
> -		if (!msta_link)
> -			continue;
> -
>  		mld_setup_link->wcid = cpu_to_le16(msta_link->wcid.idx);
>  		mld_setup_link->bss_idx = link->mt76.idx;
>  		mld_setup_link++;
> -- 
> 2.47.2
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)