linux-kernel - Re: [PATCH 2/3] clk: qcom: Add video clock controller driver for SM6350

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D8M2UHJQ86Q5.2EKUIIDRE3P73@fairphone.com>
Date: Fri, 21 Mar 2025 17:16:07 +0100
From: "Luca Weiss" <luca.weiss@...rphone.com>
To: "Dmitry Baryshkov" <dmitry.baryshkov@....qualcomm.com>
Cc: "Bjorn Andersson" <andersson@...nel.org>, "Michael Turquette"
 <mturquette@...libre.com>, "Stephen Boyd" <sboyd@...nel.org>, "Rob Herring"
 <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>, "Conor
 Dooley" <conor+dt@...nel.org>, "Taniya Das" <quic_tdas@...cinc.com>,
 "Konrad Dybcio" <konradybcio@...nel.org>,
 <~postmarketos/upstreaming@...ts.sr.ht>, <phone-devel@...r.kernel.org>,
 <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
 <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] clk: qcom: Add video clock controller driver for
 SM6350

On Fri Mar 21, 2025 at 4:55 PM CET, Dmitry Baryshkov wrote:
> On Fri, Mar 21, 2025 at 03:45:00PM +0100, Luca Weiss wrote:
>> From: Konrad Dybcio <konradybcio@...nel.org>
>> 
>> Add support for the video clock controller found on SM6350 based
>> devices.
>> 
>> Signed-off-by: Konrad Dybcio <konradybcio@...nel.org>
>> Co-developed-by: Luca Weiss <luca.weiss@...rphone.com>
>> Signed-off-by: Luca Weiss <luca.weiss@...rphone.com>
>> ---
>>  drivers/clk/qcom/Kconfig          |   9 +
>>  drivers/clk/qcom/Makefile         |   1 +
>>  drivers/clk/qcom/videocc-sm6350.c | 355 ++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 365 insertions(+)
>> 
>> +
>> +/* 600 MHz */
>> +static const struct alpha_pll_config video_pll0_config = {
>> +	.l = 0x1F,
>
> Nit: lowercase hex please. No need to repost just for the sake of this
> single line.

Sounds like there'll be a v2 anyways with dts changes, so I'll fix it!

Regards
Luca

>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
>
>
>> +	.alpha = 0x4000,
>> +	.config_ctl_val = 0x20485699,
>> +	.config_ctl_hi_val = 0x00002067,
>> +	.test_ctl_val = 0x40000000,
>> +	.test_ctl_hi_val = 0x00000002,
>> +	.user_ctl_val = 0x00000101,
>> +	.user_ctl_hi_val = 0x00004005,
>> +};
>> +
>>