linux-kernel - Re: [PATCH] x86/speculation: Remove the extra ifdef around CALL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250321170304.2b6qswvhqyv4jpvy@desk>
Date: Fri, 21 Mar 2025 10:03:04 -0700
From: Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>
To: Josh Poimboeuf <jpoimboe@...nel.org>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org,
	Andrew Cooper <andrew.cooper3@...rix.com>
Subject: Re: [PATCH] x86/speculation: Remove the extra ifdef around
 CALL_NOSPEC

On Fri, Mar 21, 2025 at 12:15:59AM -0700, Josh Poimboeuf wrote:
> On Thu, Mar 20, 2025 at 11:13:15AM -0700, Pawan Gupta wrote:
> > Commit 010c4a461c1d ("x86/speculation: Simplify and make CALL_NOSPEC
> > consistent") added an ifdef CONFIG_MITIGATION_RETPOLINE around the
> > CALL_NOSPEC definition. This is not required as this code is already under
> > a larger ifdef.
> > 
> > Remove the extra ifdef, no functional change.
> > 
> > vmlinux size remains same before and after this change.
> > 
> > CONFIG_MITIGATION_RETPOLINE=y:
> >     text	   data	    bss	    dec		hex	filename
> > 25434752	7342290	2301212	35078254	217406e	vmlinux.before
> > 25434752	7342290	2301212	35078254	217406e	vmlinux.after
> > 
> >  # CONFIG_MITIGATION_RETPOLINE is not set:
> >     text	   data	    bss	    dec		hex	filename
> > 22943094	6214994	1550152	30708240	1d49210	vmlinux.before
> > 22943094	6214994	1550152	30708240	1d49210	vmlinux.after
> > 
> > Signed-off-by: Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>
> 
> Reviewed-by: Josh Poimboeuf <jpoimboe@...nel.org>

Thanks!