linux-kernel - Re: [PATCH v3 0/2] hid-asus: asus-wmi: refactor Ally suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <CAGwozwEx-g_KCpn2XThF-ZrTxaDB1JOAK7NN10NAJ5i9Jpx_Tg@mail.gmail.com>
Date: Fri, 21 Mar 2025 18:39:19 +0100
From: Antheas Kapenekakis <lkml@...heas.dev>
To: Luke Jones <luke@...nes.dev>
Cc: linux-kernel@...r.kernel.org, hdegoede@...hat.com,
	ilpo.jarvinen@...ux.intel.com, platform-driver-x86@...r.kernel.org,
	linux-input@...r.kernel.org, bentiss@...nel.org, jikos@...nel.org,
	mario.limonciello@....com
Subject: Re: [PATCH v3 0/2] hid-asus: asus-wmi: refactor Ally suspend/resume

On Fri, 21 Mar 2025 at 04:51, Luke Jones <luke@...nes.dev> wrote:
>
> This short series refactors the Ally suspend/resume functionality in the
> asus-wmi driver along with adding support for ROG Ally MCU version checking.
>
> The version checking is then used to toggle the use of older CSEE call hacks
> that were initially used to combat Ally suspend/wake issues arising from the MCU
> not clearing a particular flag on resume. ASUS have since corrected this
> especially for Linux in newer firmware versions.
>
> - hid-asus requests the MCU version and displays a warning if the version is
>   older than the one that fixes the issue.
> - hid-asus awill also toggle the CSEE hack off, and mcu_powersave to on if the
> version is high enough.
>
> - Changelog:
>   + V2:
>     - Adjust warning message to explicitly mention suspend issues
>     - Use switch/case block to set min_version
>       - Set min_version to 0 by default and toggle hacks off
>   + V3:
>     - Fix errors picked up by test bot: incorrect return in the else block
>       of `#if IS_REACHABLE(CONFIG_ASUS_WMI)`:
>       - set_ally_mcu_hack()
>       - set_ally_mcu_powersave()
>
> Luke D. Jones (2):
>   hid-asus: check ROG Ally MCU version and warn
>   platform/x86: asus-wmi: Refactor Ally suspend/resume
>
>  drivers/hid/hid-asus.c                     | 111 +++++++++++++++++-
>  drivers/platform/x86/asus-wmi.c            | 130 ++++++++++++++-------
>  include/linux/platform_data/x86/asus-wmi.h |  13 +++
>  3 files changed, 213 insertions(+), 41 deletions(-)
>
> --
> 2.49.0
>

Since I have to also test my series on my ally and booted a dev
environment, I am also giving this a go. I'll post some results in a
bit

Antheas