[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6bf8c1c7-19f8-4727-8096-84532e6010a8@kernel.org>
Date: Fri, 21 Mar 2025 21:57:13 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Caleb James DeLisle <cjd@...ns.fr>, linux-mips@...r.kernel.org
Cc: Thomas Gleixner <tglx@...utronix.de>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
Daniel Lezcano <daniel.lezcano@...aro.org>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, benjamin.larsson@...exis.eu
Subject: Re: [PATCH v1 6/8] dt-bindings: mips: Add EcoNet platform binding
On 21/03/2025 14:46, Caleb James DeLisle wrote:
> Document the top-level device tree binding for EcoNet MIPS-based SoCs.
>
> Signed-off-by: Caleb James DeLisle <cjd@...ns.fr>
> ---
> .../devicetree/bindings/mips/econet.yaml | 27 +++++++++++++++++++
> 1 file changed, 27 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mips/econet.yaml
>
> diff --git a/Documentation/devicetree/bindings/mips/econet.yaml b/Documentation/devicetree/bindings/mips/econet.yaml
> new file mode 100644
> index 000000000000..44da78dc1e29
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mips/econet.yaml
> @@ -0,0 +1,27 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mips/econet.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: EcoNet MIPS SoCs
> +
> +maintainers:
> + - Caleb James DeLisle <cjd@...ns.fr>
> +
> +description:
> + Boards with an EcoNet SoC shall have the following properties.
Drop description, useless and not even correct.
> +
> +properties:
> + $nodename:
> + const: '/'
> +
> + compatible:
> + oneOf:
> + - description: Boards with EcoNet EN751221 family SoC
> + items:
> + - const: econet,en751221
That's a soc. You need board compatible as well. Look at other
upstreamed code.
Best regards,
Krzysztof
Powered by blists - more mailing lists