linux-kernel - Re: [PATCH 2/4] EDAC, altera: update driver to reflect hw/yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250321211203.GEZ93WI8tLaTJTxHmF@fat_crate.local>
Date: Fri, 21 Mar 2025 22:12:03 +0100
From: Borislav Petkov <bp@...en8.de>
To: Matthew Gerlach <matthew.gerlach@...era.com>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	dinguyen@...nel.org, tony.luck@...el.com, james.morse@....com,
	mchehab@...nel.org, rric@...nel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org
Subject: Re: [PATCH 2/4] EDAC, altera: update driver to reflect hw/yaml

On Thu, Mar 20, 2025 at 09:46:20AM -0700, Matthew Gerlach wrote:
> The device tree subnodes, and hardware, for the eccmgr are
> the same for Arria10, Stratix10, and Agilex. Update driver
> to allow the subnodes to be allowed for "altr,socfpga-s10-ecc-manager".
> 
> Signed-off-by: Matthew Gerlach <matthew.gerlach@...era.com>
> ---
>  drivers/edac/altera_edac.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
> index 3e971f902363..895a5beb700f 100644
> --- a/drivers/edac/altera_edac.c
> +++ b/drivers/edac/altera_edac.c
> @@ -1030,6 +1030,9 @@ static int __init __maybe_unused altr_init_a10_ecc_device_type(char *compat)
>  
>  	np = of_find_compatible_node(NULL, NULL,
>  				     "altr,socfpga-a10-ecc-manager");
> +	if (!np)
> +		np = of_find_compatible_node(NULL, NULL,
> +					     "altr,socfpga-s10-ecc-manager");

Please slap a comment above this here - one can see the difference between the
two calls only after staring at them for a couple of minutes and wonder
where's Waldo.

:-P

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette