linux-kernel - Re: [PATCH v17 3/4] PCI/DOE: Expose the DOE features via sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250321214158.GA1162292@bhelgaas>
Date: Fri, 21 Mar 2025 16:41:58 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Alistair Francis <alistair@...stair23.me>
Cc: bhelgaas@...gle.com, linux-pci@...r.kernel.org,
	Jonathan.Cameron@...wei.com, lukas@...ner.de,
	alex.williamson@...hat.com, christian.koenig@....com,
	kch@...dia.com, gregkh@...uxfoundation.org, logang@...tatee.com,
	linux-kernel@...r.kernel.org, alistair23@...il.com,
	chaitanyak@...dia.com, rdunlap@...radead.org
Subject: Re: [PATCH v17 3/4] PCI/DOE: Expose the DOE features via sysfs

On Thu, Mar 06, 2025 at 05:52:10PM +1000, Alistair Francis wrote:
> The PCIe 6 specification added support for the Data Object
> Exchange (DOE).
> When DOE is supported the DOE Discovery Feature must be implemented per
> PCIe r6.1 sec 6.30.1.1. DOE allows a requester to obtain
> information about the other DOE features supported by the device.

> +#ifdef CONFIG_SYSFS
> +static ssize_t doe_discovery_show(struct device *dev,
> +				  struct device_attribute *attr,
> +				  char *buf)
> +{
> +	return sysfs_emit(buf, "0001:00\n");
> +}
> +DEVICE_ATTR_RO(doe_discovery);

I think this needs:

  static DEVICE_ATTR_RO(doe_discovery);

Otherwise sparse complains:

  $ make C=2 drivers/pci/doe.o
    CHECK   scripts/mod/empty.c
    CALL    scripts/checksyscalls.sh
    DESCEND objtool
    INSTALL libsubcmd_headers
    CHECK   drivers/pci/doe.c
  drivers/pci/doe.c:109:1: warning: symbol 'dev_attr_doe_discovery' was not declared. Should it be static?


Right?  I added this in, so we're all set unless you think that's
wrong.

Bjorn