linux-kernel - Re: [PATCH] bpf: Remove duplicate judgments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPhsuW5-m9cjewV7obGagx9edMRFpoL3xDQMWyCckR2Ro=+=Qw@mail.gmail.com>
Date: Thu, 20 Mar 2025 22:23:03 -0700
From: Song Liu <song@...nel.org>
To: Feng Yang <yangfeng59949@....com>
Cc: andrii@...nel.org, ast@...nel.org, bpf@...r.kernel.org, 
	daniel@...earbox.net, eddyz87@...il.com, haoluo@...gle.com, 
	john.fastabend@...il.com, jolsa@...nel.org, kpsingh@...nel.org, 
	linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org, 
	martin.lau@...ux.dev, mathieu.desnoyers@...icios.com, 
	mattbobrowski@...gle.com, mhiramat@...nel.org, rostedt@...dmis.org, 
	sdf@...ichev.me, yonghong.song@...ux.dev
Subject: Re: [PATCH] bpf: Remove duplicate judgments

On Thu, Mar 20, 2025 at 9:36 PM Feng Yang <yangfeng59949@....com> wrote:
>
[...]
>
> So the return of bpf_perf_event_read_value_proto can be done through the bpf_base_func_proto function.
> bpf_base_func_proto
>         ......
>         case BPF_FUNC_perf_event_read_value:
>                 return bpf_get_perf_event_read_value_proto();
>
> I think this can be removed.

I see. I misunderstood this part because I was reading code before
ae0a457f5d33c336f3c4259a258f8b537531a04b. Now it looks good.

Acked-by: Song Liu <song@...nel.org>

> > For future patches, please read Documentation/bpf/bpf_devel_QA.rst
> > and follow rules for email subject, etc. For example, this patch should
> > have a subject like "[PATCH bpf-next] xxx".
>
> Thank you very much for your suggestion. I will pay attention to it next time.
>