linux-kernel - Re: [PATCH 1/2] ASoC: SOF: MediaTek: Add mt8196 hardware support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e369f6ec539454ad7d4f30389fec4ae58d1482ae.camel@mediatek.com>
Date: Fri, 21 Mar 2025 05:51:22 +0000
From: Hailong Fan (范海龙) <Hailong.Fan@...iatek.com>
To: "krzk@...nel.org" <krzk@...nel.org>
CC: "perex@...ex.cz" <perex@...ex.cz>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Jjian Zhou (周建)
	<Jjian.Zhou@...iatek.com>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "pierre-louis.bossart@...ux.dev"
	<pierre-louis.bossart@...ux.dev>, "kai.vehmanen@...ux.intel.com"
	<kai.vehmanen@...ux.intel.com>,
	Xiangzhi Tang (唐相志)
	<Xiangzhi.Tang@...iatek.com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-sound@...r.kernel.org"
	<linux-sound@...r.kernel.org>, "broonie@...nel.org" <broonie@...nel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "tiwai@...e.com"
	<tiwai@...e.com>, "robh@...nel.org" <robh@...nel.org>, "lgirdwood@...il.com"
	<lgirdwood@...il.com>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "yung-chuan.liao@...ux.intel.com"
	<yung-chuan.liao@...ux.intel.com>, Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "peter.ujfalusi@...ux.intel.com"
	<peter.ujfalusi@...ux.intel.com>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"daniel.baluta@....com" <daniel.baluta@....com>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>,
	"ranjani.sridharan@...ux.intel.com" <ranjani.sridharan@...ux.intel.com>,
	"sound-open-firmware@...a-project.org" <sound-open-firmware@...a-project.org>
Subject: Re: [PATCH 1/2] ASoC: SOF: MediaTek: Add mt8196 hardware support

On Thu, 2025-03-20 at 08:52 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On Thu, Mar 20, 2025 at 11:17:24AM +0800, hailong.fan wrote:
> > +
> > +void mt8196_sof_hifixdsp_shutdown(struct snd_sof_dev *sdev)
> > +{
> > +     /* set RUNSTALL to stop core */
> > +     snd_sof_dsp_update_bits(sdev, DSP_REG_BAR,
> > ADSP_HIFI_RUNSTALL,
> > +                             RUNSTALL, RUNSTALL);
> > +
> > +     /* assert core reset */
> > +     snd_sof_dsp_update_bits(sdev, DSP_REG_BAR,
> > ADSP_CFGREG_SW_RSTN,
> > +                             SW_RSTN_C0 | SW_DBG_RSTN_C0,
> > +                             SW_RSTN_C0 | SW_DBG_RSTN_C0);
> > +}
> > +
> 
> Drop stray blank line.
OK, will fix in v2, thx.
> 
> > diff --git a/sound/soc/sof/mediatek/mt8196/mt8196.c
> > b/sound/soc/sof/mediatek/mt8196/mt8196.c
> > new file mode 100644
> > index 000000000000..364069ce9954
> > --- /dev/null
> > +++ b/sound/soc/sof/mediatek/mt8196/mt8196.c
> > @@ -0,0 +1,650 @@
> > +// SPDX-License-Identifier: GPL-2.0
> 
> Look here
OK, will fix in v2, thx.
/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */
> 
> > +/*
> > + * Copyright (c) 2025 MediaTek Inc.
> > + * Author: Hailong Fan <hailong.fan@...iatek.com>
> > + */
> 
> ...
> 
> > +
> > +static const struct of_device_id sof_of_mt8196_ids[] = {
> > +     { .compatible = "mediatek,mt8196-dsp", .data =
> > &sof_of_mt8196_desc},
> 
> Bindings are before users.
Will change patch order in v2, thx.
> 
> > +     { }
> > +};
> > +MODULE_DEVICE_TABLE(of, sof_of_mt8196_ids);
> > +
> > +/* DT driver definition */
> > +static struct platform_driver snd_sof_of_mt8196_driver = {
> > +     .probe = sof_of_probe,
> > +     .remove = sof_of_remove,
> > +     .shutdown = sof_of_shutdown,
> > +     .driver = {
> > +     .name = "sof-audio-of-mt8196",
> > +             .pm = &sof_of_pm,
> > +             .of_match_table = sof_of_mt8196_ids,
> > +     },
> > +};
> > +module_platform_driver(snd_sof_of_mt8196_driver);
> > +
> > +MODULE_LICENSE("Dual BSD/GPL");
> 
> And here Hm? Don't fake the licensing.
Will fix in v2, thx.
/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-
Clause) */
> 
> > +MODULE_DESCRIPTION("SOF support for MT8196 platforms");
> > +MODULE_IMPORT_NS("SND_SOC_SOF_XTENSA");
> 
> Is this correct?
> 
> 
> Best regards,
> Krzysztof
>