linux-kernel - Re: [PATCH] mm/page_alloc: Simplify free_page_is_bad by removing free_page_is_bad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5fb25a84-f047-40f1-a3a2-b4f3c65fba06@linux.dev>
Date: Fri, 21 Mar 2025 14:09:58 +0800
From: Ye Liu <ye.liu@...ux.dev>
To: Anshuman Khandual <anshuman.khandual@....com>, akpm@...ux-foundation.org
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org,
 Ye Liu <liuye@...inos.cn>
Subject: Re: [PATCH] mm/page_alloc: Simplify free_page_is_bad by removing
 free_page_is_bad_report


在 2025/3/21 12:39, Anshuman Khandual 写道:
>
> On 3/21/25 06:37, Ye Liu wrote:
>> From: Ye Liu <liuye@...inos.cn>
>>
>> This patch refactors the free_page_is_bad function by directly calling
>> bad_page() instead of using the intermediary function
>> free_page_is_bad_report(). The removal of free_page_is_bad_report()
>> reduces unnecessary indirection, making the code cleaner and easier to
>> read.
>>
>> The functionality remains the same, as free_page_is_bad_report() was
>> merely a wrapper for the bad_page() call. The patch also improves
>> maintainability by reducing the function call depth.
> Seems to be a sensible clean up indeed.
>
>> Signed-off-by: Ye Liu <liuye@...inos.cn>
>> ---
>>  mm/page_alloc.c | 9 ++-------
>>  1 file changed, 2 insertions(+), 7 deletions(-)
>>
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index 61d6a3b1b286..2842da893eea 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -933,19 +933,14 @@ static const char *page_bad_reason(struct page *page, unsigned long flags)
>>  	return bad_reason;
>>  }
>>  
>> -static void free_page_is_bad_report(struct page *page)
>> -{
>> -	bad_page(page,
>> -		 page_bad_reason(page, PAGE_FLAGS_CHECK_AT_FREE));
>> -}
>> -
>>  static inline bool free_page_is_bad(struct page *page)
>>  {
>>  	if (likely(page_expected_state(page, PAGE_FLAGS_CHECK_AT_FREE)))
>>  		return false;
>>  
>>  	/* Something has gone sideways, find it */
>> -	free_page_is_bad_report(page);
>> +	bad_page(page,
>> +		 page_bad_reason(page, PAGE_FLAGS_CHECK_AT_FREE));
> Please fold these above two lines into a single line instead.
>
> bad_page(page, page_bad_reason(page, PAGE_FLAGS_CHECK_AT_FREE));
>
>>  	return true;
>>  }
>>  
> With the above suggested change in place.
>
> Reviewed-by: Anshuman Khandual <anshuman.khandual@....com>

Thank you for the suggestion. I'll make the adjustment and submit a new patch.
Appreciate your time and the review!

Thanks,
Ye Liu