linux-kernel - Re: [net-next PATCH v13 10/14] mfd: an8855: Add support for Airoha AN8855 Switch MFD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202503211428.H4VdWHco-lkp@intel.com>
Date: Fri, 21 Mar 2025 14:12:55 +0800
From: kernel test robot <lkp@...el.com>
To: Christian Marangi <ansuelsmth@...il.com>, Lee Jones <lee@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Vladimir Oltean <olteanv@...il.com>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	Maxime Chevallier <maxime.chevallier@...tlin.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, upstream@...oha.com
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org
Subject: Re: [net-next PATCH v13 10/14] mfd: an8855: Add support for Airoha
 AN8855 Switch MFD

Hi Christian,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Marangi/dt-bindings-nvmem-Document-support-for-Airoha-AN8855-Switch-EFUSE/20250315-235040
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250315154407.26304-11-ansuelsmth%40gmail.com
patch subject: [net-next PATCH v13 10/14] mfd: an8855: Add support for Airoha AN8855 Switch MFD
config: i386-randconfig-006-20250321 (https://download.01.org/0day-ci/archive/20250321/202503211428.H4VdWHco-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250321/202503211428.H4VdWHco-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503211428.H4VdWHco-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: drivers/mfd/airoha-an8855.o: in function `an8855_core_probe':
>> drivers/mfd/airoha-an8855.c:376: undefined reference to `devm_mdio_regmap_init'


vim +376 drivers/mfd/airoha-an8855.c

   352	
   353	static int an8855_core_probe(struct mdio_device *mdiodev)
   354	{
   355		struct regmap *regmap, *regmap_phy;
   356		struct device *dev = &mdiodev->dev;
   357		struct an8855_core_priv *priv;
   358		struct gpio_desc *reset_gpio;
   359		u32 val;
   360		int ret;
   361	
   362		priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
   363		if (!priv)
   364			return -ENOMEM;
   365	
   366		priv->bus = mdiodev->bus;
   367		priv->switch_addr = mdiodev->addr;
   368		/* No DMA for mdiobus, mute warning for DMA mask not set */
   369		dev->dma_mask = &dev->coherent_dma_mask;
   370	
   371		regmap = devm_regmap_init(dev, NULL, priv, &an8855_regmap_config);
   372		if (IS_ERR(regmap))
   373			return dev_err_probe(dev, PTR_ERR(regmap),
   374					     "regmap initialization failed\n");
   375	
 > 376		regmap_phy = devm_mdio_regmap_init(dev, priv, &an8855_regmap_phy_config);
   377		if (IS_ERR(regmap_phy))
   378			return dev_err_probe(dev, PTR_ERR(regmap_phy),
   379					     "regmap phy initialization failed\n");
   380	
   381		reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
   382		if (IS_ERR(reset_gpio))
   383			return PTR_ERR(reset_gpio);
   384	
   385		if (reset_gpio) {
   386			usleep_range(100000, 150000);
   387			gpiod_set_value_cansleep(reset_gpio, 0);
   388			usleep_range(100000, 150000);
   389			gpiod_set_value_cansleep(reset_gpio, 1);
   390	
   391			/* Poll HWTRAP reg to wait for Switch to fully Init */
   392			ret = regmap_read_poll_timeout(regmap, AN8855_HWTRAP, val,
   393						       val, 20, 200000);
   394			if (ret)
   395				return ret;
   396		}
   397	
   398		ret = an8855_read_switch_id(dev, regmap);
   399		if (ret)
   400			return ret;
   401	
   402		/* Release global PHY power down */
   403		ret = regmap_write(regmap, AN8855_RG_GPHY_AFE_PWD, 0x0);
   404		if (ret)
   405			return ret;
   406	
   407		return devm_mfd_add_devices(dev, PLATFORM_DEVID_AUTO, an8855_core_childs,
   408					    ARRAY_SIZE(an8855_core_childs), NULL, 0,
   409					    NULL);
   410	}
   411	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki