linux-kernel - Re: [PATCH ath-next v11 00/13] wifi: ath12k: add Ath12k AHB driver support for IPQ5332

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <10fd0006-8428-4bc6-9578-2a05dc1382e0@quicinc.com>
Date: Fri, 21 Mar 2025 15:37:49 +0530
From: Raj Kumar Bhagat <quic_rajkbhag@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: <ath12k@...ts.infradead.org>, Johannes Berg <johannes@...solutions.net>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, Jeff Johnson <jjohnson@...nel.org>,
        <linux-wireless@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH ath-next v11 00/13] wifi: ath12k: add Ath12k AHB driver
 support for IPQ5332

On 3/18/2025 1:30 PM, Krzysztof Kozlowski wrote:
> On Tue, Mar 18, 2025 at 02:16:26AM +0530, Raj Kumar Bhagat wrote:
>> Currently, Ath12k driver only supports WiFi devices that are based on
>> PCI bus. New Ath12k device IPQ5332 is based on AHB bus. Hence, add
>> Ath12k AHB support for IPQ5332.
>>
>> IPQ5332 is IEEE802.11be 2 GHz 2x2 Wifi device. To bring-up IPQ5332
>> device:
>> - Add hardware parameters for IPQ5332.
>> - CE register address space in IPQ5332 is separate from WCSS register
>>   space. Hence, add logic to remap CE register address.
>> - Add support for fixed QMI firmware memory for IPQ5332.
>> - Support userPD handling for WCSS secure PIL driver to enable ath12k
>>   AHB support.
>>
>> NOTE:
>> The working upstream DTS changes for this series have been posted as a
>> separate series.
>> [PATCH v2] arm64: dts: qcom: add wifi node for IPQ5332 based RDP441
>>
>> v11:
>> - Updated Kconfig for ATH12k AHB.
>> - Replaced the API devm_ioremap_wc() with devm_memremap to fix ath12k-check
>>   warning: "warning: cast removes address space '__iomem' of expression"
>> - Rebased on latest ToT.
>> - Removed tag "Reviewed-by: Vasanthakumar Thiagarajan", in the updated
>>   patch [11/13] wifi: ath12k: Power up userPD
> 
> 
> This is v11 and still sent in a way it messes with toolset:
> 
>   b4 diff -C 20250317204639.1864742-2-quic_rajkbhag@...cinc.com
>   Grabbing thread from lore.kernel.org/all/20250317204639.1864742-2-quic_rajkbhag@...cinc.com/t.mbox.gz
>   Checking for older revisions
>     Added from v10: 14 patches
>   ---
>   Analyzing 135 messages in the thread
>   Preparing fake-am for v11: dt-bindings: net: wireless: describe the ath12k AHB module for IPQ5332
>   ERROR: Could not fake-am version v11
>   ---
>   Could not create fake-am range for upper series v11
> 
> Can you fix your process so the tools will be happy? Please read
> carefully your internal guideline go/upstream before posting next
> version.
> 

It may be because, I did not use b4 tool for this.
Will send the next version with b4 tool.