linux-kernel - Re: [PATCH v2 3/8] drivers/perf: hisi: Use ACPI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250321111318.0000455e@huawei.com>
Date: Fri, 21 Mar 2025 11:13:18 +0000
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Yicong Yang <yangyicong@...wei.com>
CC: <will@...nel.org>, <mark.rutland@....com>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	<hejunhao3@...wei.com>, <prime.zeng@...ilicon.com>, <linuxarm@...wei.com>,
	<yangyicong@...ilicon.com>, <wangyushan12@...wei.com>
Subject: Re: [PATCH v2 3/8] drivers/perf: hisi: Use ACPI driver_data to
 retrieve SLLC PMU information

On Fri, 21 Mar 2025 15:38:41 +0800
Yicong Yang <yangyicong@...wei.com> wrote:

> From: Junhao He <hejunhao3@...wei.com>
> 
> Make use of struct acpi_device_id::driver_data for version specific
> information rather than judge the version register. This will help
> to simplify the probe process and also a bit easier for extension.
> 
> Factor out SLLC register definition to struct hisi_sllc_pmu_regs.
> No functional changes intended.
> 
> Signed-off-by: Junhao He <hejunhao3@...wei.com>
> Signed-off-by: Yicong Yang <yangyicong@...ilicon.com>
LGTM
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>