linux-kernel - Re: [PATCH -next] drm/i915/display: Fix build error without DRM_FBDEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y0wyblpd.fsf@intel.com>
Date: Fri, 21 Mar 2025 14:41:02 +0200
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Thomas Zimmermann <tzimmermann@...e.de>, Yue Haibing
 <yuehaibing@...wei.com>, rodrigo.vivi@...el.com,
 joonas.lahtinen@...ux.intel.com, tursulin@...ulin.net, airlied@...il.com,
 simona@...ll.ch, dev@...khorst.se
Cc: intel-gfx@...ts.freedesktop.org, intel-xe@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] drm/i915/display: Fix build error without
 DRM_FBDEV_EMULATION

On Mon, 17 Mar 2025, Thomas Zimmermann <tzimmermann@...e.de> wrote:
> Am 15.03.25 um 13:01 schrieb Yue Haibing:
>> In file included from <command-line>:
>> ./drivers/gpu/drm/i915/display/intel_fbdev.h: In function ‘intel_fbdev_framebuffer’:
>> ./drivers/gpu/drm/i915/display/intel_fbdev.h:32:16: error: ‘NULL’ undeclared (first use in this function)
>>     32 |         return NULL;
>>        |                ^~~~
>> ./drivers/gpu/drm/i915/display/intel_fbdev.h:1:1: note: ‘NULL’ is defined in header ‘<stddef.h>’; did you forget to ‘#include <stddef.h>’?
>>    +++ |+#include <stddef.h>
>>      1 | /* SPDX-License-Identifier: MIT */
>> ./drivers/gpu/drm/i915/display/intel_fbdev.h:32:16: note: each undeclared identifier is reported only once for each function it appears in
>>     32 |         return NULL;
>>        |                ^~~~
>>
>> Build fails if CONFIG_DRM_FBDEV_EMULATION is n, add missing header file.
>>
>> Fixes: 9fa154f40eb6 ("drm/{i915,xe}: Run DRM default client setup")
>> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
>
> Acked-by: Thomas Zimmermann <tzimmermann@...e.de>

Merged to drm-intel-next, thanks for the patch and ack.

BR,
Jani.

>
>> ---
>>   drivers/gpu/drm/i915/display/intel_fbdev.h | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.h b/drivers/gpu/drm/i915/display/intel_fbdev.h
>> index ca2c8c438f02..89bad3a2b01a 100644
>> --- a/drivers/gpu/drm/i915/display/intel_fbdev.h
>> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.h
>> @@ -6,6 +6,8 @@
>>   #ifndef __INTEL_FBDEV_H__
>>   #define __INTEL_FBDEV_H__
>>   
>> +#include <linux/types.h>
>> +
>>   struct drm_fb_helper;
>>   struct drm_fb_helper_surface_size;
>>   struct drm_i915_private;

-- 
Jani Nikula, Intel