linux-kernel - Re: [PATCH] staging: greybus: fix line length issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15e28afa-6faa-4e3e-d92a-b06a3e3b474@inria.fr>
Date: Fri, 21 Mar 2025 13:48:42 +0100 (CET)
From: Julia Lawall <julia.lawall@...ia.fr>
To: ErickKaranja <karanja99erick@...il.com>
cc: hvaibhav.linux@...il.com, johan@...nel.org, elder@...nel.org, 
    gregkh@...uxfoundation.org, outreachy@...ts.linux.dev, 
    greybus-dev@...ts.linaro.org, linux-staging@...ts.linux.dev, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: greybus: fix line length issue



On Fri, 21 Mar 2025, ErickKaranja wrote:

> Fix line length exceeding 100 columns in arche-platform.c. The code now
> follows Linux kernel coding style guidelines by keeping lines under the
> maximum allowed length of 100 characters.

Thanks for the patch.

In your log message you can try to avoid the word "Fix".  Probably most
patches fix something, so it doesn't give much information.  And it
doesn't say anything about how you fixed it.  Here it could be "Reduce a
line that exceeds 100 columns".  You don't have to mention the file name,
because one can easily see that from looking at the patch.

>
> Reported by checkpatch:
>
> CHECK: line length of 101 exceeds 100 columns
>
> Signed-off-by: ErickKaranja <karanja99erick@...il.com>

Here you should have Erick Karanja, not ErickKaranja.

thanks,
julia

> ---
>  drivers/staging/greybus/arche-platform.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
> index d48464390f58..1a82a7a3991c 100644
> --- a/drivers/staging/greybus/arche-platform.c
> +++ b/drivers/staging/greybus/arche-platform.c
> @@ -179,8 +179,8 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
>  				 */
>  				if (arche_pdata->wake_detect_state !=
>  						WD_STATE_COLDBOOT_START) {
> -					arche_platform_set_wake_detect_state(arche_pdata,
> -									     WD_STATE_COLDBOOT_TRIG);
> +					arche_platform_set_wake_detect_state
> +						(arche_pdata, WD_STATE_COLDBOOT_TRIG);
>  					spin_unlock_irqrestore(&arche_pdata->wake_lock,
>  							       flags);
>  					return IRQ_WAKE_THREAD;
> --
> 2.43.0
>
>
>