linux-kernel - [PATCH] kstrtox: Add support for enabled and disabled in kstrtobool()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250321022538.1532445-1-superm1@kernel.org>
Date: Thu, 20 Mar 2025 21:25:01 -0500
From: Mario Limonciello <superm1@...nel.org>
To: mario.limonciello@....com,
	Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-kernel@...r.kernel.org
Subject: [PATCH] kstrtox: Add support for enabled and disabled in kstrtobool()

From: Mario Limonciello <mario.limonciello@....com>

In some places in the kernel there is a design pattern for sysfs
attributes to use kstrtobool() in store() and str_enabled_disabled()
in show().

This is counterintuitive to interact with because kstrtobool() takes
on/off but str_enabled_disabled() shows enabled/disabled. Some of those
sysfs uses could switch to str_on_off() but for some attributes
enabled/disabled really makes more sense.

Add support for kstrtobool() to accept enabled/disabled.

Signed-off-by: Mario Limonciello <mario.limonciello@....com>
---
 lib/kstrtox.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/kstrtox.c b/lib/kstrtox.c
index d586e6af5e5a6..bdde40cd69d78 100644
--- a/lib/kstrtox.c
+++ b/lib/kstrtox.c
@@ -351,6 +351,8 @@ int kstrtobool(const char *s, bool *res)
 		return -EINVAL;

 	switch (s[0]) {
+	case 'e':
+	case 'E':
 	case 'y':
 	case 'Y':
 	case 't':
@@ -358,6 +360,8 @@ int kstrtobool(const char *s, bool *res)
 	case '1':
 		*res = true;
 		return 0;
+	case 'd':
+	case 'D':
 	case 'n':
 	case 'N':
 	case 'f':
-- 
2.43.0