linux-kernel - Re: [greybus-dev] [PATCH] staging: greybus: fix line length issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <acbe5688-9be4-489b-8a9c-4950dc3b8133@quicinc.com>
Date: Fri, 21 Mar 2025 07:37:30 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: ErickKaranja <karanja99erick@...il.com>, <hvaibhav.linux@...il.com>,
        <johan@...nel.org>, <elder@...nel.org>, <gregkh@...uxfoundation.org>,
        <outreachy@...ts.linux.dev>
CC: <greybus-dev@...ts.linaro.org>, <linux-staging@...ts.linux.dev>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [greybus-dev] [PATCH] staging: greybus: fix line length issue

On 3/21/2025 4:55 AM, ErickKaranja wrote:
> Fix line length exceeding 100 columns in arche-platform.c. The code now
> follows Linux kernel coding style guidelines by keeping lines under the
> maximum allowed length of 100 characters.
> 
> Reported by checkpatch:
> 
> CHECK: line length of 101 exceeds 100 columns
> 
> Signed-off-by: ErickKaranja <karanja99erick@...il.com>
> ---
>  drivers/staging/greybus/arche-platform.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
> index d48464390f58..1a82a7a3991c 100644
> --- a/drivers/staging/greybus/arche-platform.c
> +++ b/drivers/staging/greybus/arche-platform.c
> @@ -179,8 +179,8 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
>  				 */
>  				if (arche_pdata->wake_detect_state !=
>  						WD_STATE_COLDBOOT_START) {
> -					arche_platform_set_wake_detect_state(arche_pdata,
> -									     WD_STATE_COLDBOOT_TRIG);
> +					arche_platform_set_wake_detect_state
> +						(arche_pdata, WD_STATE_COLDBOOT_TRIG);
>  					spin_unlock_irqrestore(&arche_pdata->wake_lock,
>  							       flags);
>  					return IRQ_WAKE_THREAD;

I see you already received some good feedback. However I think the most
important feedback wasn't given, namely that checkpatch performs rigorous
enforcement of Coding Style guidelines that themselves are not always rigorous.

For line length the Coding Style still says the "preferred limit" is 80
columns. But whether it is 80 or 100, the Coding Style has this very important
caveat: Statements longer than [the limit] should be broken into sensible
chunks, unless exceeding [the limit] significantly increases readability.

<https://www.kernel.org/doc/html/latest/process/coding-style.html#breaking-long-lines-and-strings>

Obviously this is subjective, but for me the original code is significantly
more readable than the patched code.

So the takeaway is that not every checkpatch issue should be "fixed".

/jeff