linux-kernel - Re: [PATCH] hrtimer: Fix the incorrect initialization of timer->is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250322082403.3126947-1-cuiguoqi@kylinos.cn>
Date: Sat, 22 Mar 2025 16:24:03 +0800
From: cuiguoqi <cuiguoqi@...inos.cn>
To: tglx@...utronix.de
Cc: anna-maria@...utronix.de,
	bigeasy@...utronix.de,
	clrkwllms@...nel.org,
	cuiguoqi@...inos.cn,
	frederic@...nel.org,
	linux-kernel@...r.kernel.org,
	linux-rt-devel@...ts.linux.dev,
	rostedt@...dmis.org
Subject: Re: [PATCH] hrtimer: Fix the incorrect initialization of timer->is_hard

Hi tglx,

First of all, I'd like to thank you for your reply and for pointing out the email issue. 

As you've accurately noted, when PREEMPT_RT is disabled, it introduces a certain
degree of ambiguity for kernel developers. So far, no malfunctions have been
observed as a direct consequence of this.

This issue came to light during kernel development when using the is_hard flag, 
where the expected logic was not achieved.Naturally, we opted for the more reliable 
is_soft flag to address the situation.

Consequently, when PREEMPT_RT is disabled, there is a potential risk if developers
choose to use the is_hard flag. I firmly believe this risk should not be overlooked.

I concur with your analysis that one of these flags is redundant. In fact,
it might be possible to consolidate them based on the overall requirements. 

Thanks.

Cui Guoqi