linux-kernel - RE: [PATCH] drm: renesas: Extend RZ/G2L supported KMS formats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TY3PR01MB1134694B056667D0B3D18FA2086DA2@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Date: Sat, 22 Mar 2025 10:12:51 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: Biju Das <biju.das.jz@...renesas.com>, laurent.pinchart
	<laurent.pinchart@...asonboard.com>, kieran.bingham
	<kieran.bingham@...asonboard.com>
CC: "linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, Kieran
 Bingham <kieran.bingham+renesas@...asonboard.com>, Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
	Simona Vetter <simona@...ll.ch>
Subject: RE: [PATCH] drm: renesas: Extend RZ/G2L supported KMS formats

Hi Laurent,

> -----Original Message-----
> From: Biju Das <biju.das.jz@...renesas.com>
> Sent: 22 March 2025 09:29
> Subject: RE: [PATCH] drm: renesas: Extend RZ/G2L supported KMS formats
> 
> Hi Laurent,
> 
> > -----Original Message-----
> > From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> > Sent: 21 March 2025 22:33
> > Subject: Re: [PATCH] drm: renesas: Extend RZ/G2L supported KMS formats
> >
> > Hi Kieran,
> >
> > Thank you for the patch.
> >
> > On Fri, Mar 21, 2025 at 05:22:19PM +0000, Kieran Bingham wrote:
> > > From: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
> > >
> > > The RZ/G2L driver utilises the VSPD to read data from input sources.
> > >
> > > The rzg2l_du_kms component lists a restricted subset of the
> > > capabilities of the VSPd which prevents additional formats from
> > > being used for
> >
> > s/VSPd/VSPD/
> >
> > > display planes.
> > >
> > > The supported display plane formats are mapped in rzg2l_du_vsp_formats[].
> > >
> > > Extend the rzg2l_du_format_infos[] table with the corresponding
> > > mappings between the supported DRM formats and the formats exposed
> > > by the VSP in rzg2l_du_vsp_formats, maintaining the same ordering in both tables.
> >
> > Given the other replies to this patch, you may want to extend the
> > commit message to explain why this is fine, and how the VSPD will convert YUV formats to RGB.
> >
> > Now this makes realize we should implement support for colorspace in
> > the VSPD driver... It's a separate issue.
> >
> > > Signed-off-by: Kieran Bingham
> > > <kieran.bingham+renesas@...asonboard.com>
> > > ---
> > >  drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c | 141
> > > ++++++++++++++++++-
> > >  1 file changed, 136 insertions(+), 5 deletions(-)
> > >
> > > Prior to this patch, kmstest reports all of these formats as
> > > supported by the Planes, but using them fails during
> > > rzg2l_du_fb_create() as the corresponding format isn't found in rzg2l_du_format_info.
> > >
> > > This patch now lets me capture and render pixelformats from the
> > > Mali-C55 direct to an attached DSI panel on the Kakip board.
> > >
> > > Patch tested with kms-tests:
> > >
> > > PYTHONPATH=/usr/lib/aarch64-linux-gnu/python3.11/site-packages
> > > ./tests/kms-test-formats.py Testing plane formats: SUCCESS
> > >
> > >
> > > diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c
> > > b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c
> > > index b1266fbd9598..a5e96f863172 100644
> > > --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c
> > > +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c
> > > @@ -36,8 +36,61 @@
> > >
> > >  static const struct rzg2l_du_format_info rzg2l_du_format_infos[] = {
> > >  	{
> > > -		.fourcc = DRM_FORMAT_XRGB8888,
> > > -		.v4l2 = V4L2_PIX_FMT_XBGR32,
> > > +		.fourcc = DRM_FORMAT_RGB332,
> > > +		.v4l2 = V4L2_PIX_FMT_RGB332,
> > > +		.bpp = 8,
> > > +		.planes = 1,
> > > +		.hsub = 1,
> >
> > hsub isn't used in the driver, should it be removed (in a separate
> > patch of course) ? Or is that a sign there's a bug somewhere ?
> >
> > Actually, bpp isn't used either. Biju, could you look into this, and
> > check if we should remove the fields or use them ?
> 
> Both bpp and hsub unused previously.
> 
> bpp still can be removed as it is unused like R-Car Gen3.

Correction, On R-Car Gen3 it is used by du_plane where as
RZ/G2L does not support DU hardware planes.

Cheere,
Biju