linux-kernel - Re: [PATCH] wifi: mt76: mt7996: prevent uninit return in mt7996_mac_sta_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3bef0804-83ca-44e1-87da-db5b777d68cb@web.de>
Date: Sat, 22 Mar 2025 12:44:51 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Qasim Ijaz <qasdev00@...il.com>, linux-wireless@...r.kernel.org,
 linux-mediatek@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Angelo Gioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Bo Jiao <bo.jiao@...iatek.com>, Dan Carpenter <dan.carpenter@...aro.org>,
 Felix Fietkau <nbd@....name>, Johannes Berg <johannes@...solutions.net>,
 Lorenzo Bianconi <lorenzo@...nel.org>,
 Matthias Brugger <matthias.bgg@...il.com>,
 Peter Chiu <chui-hao.chiu@...iatek.com>, Ryder Lee <ryder.lee@...iatek.com>,
 Sean Wang <sean.wang@...iatek.com>, Shayne Chen <shayne.chen@...iatek.com>
Subject: Re: [PATCH] wifi: mt76: mt7996: prevent uninit return in
 mt7996_mac_sta_add_links

> If link_conf_dereference_protected() or mt7996_vif_link()
> or link_sta_dereference_protected() fail the code jumps to

                                      call failed?


> the error_unlink label and returns ret which is uninitialised.

                                     a value from a local variable
                                     which was not initialised properly?


Can the summary phrase be improved also another bit?

Regards,
Markus