linux-kernel - Re: [PATCH] staging: bcm2835-camera: Modify function call formatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2503221557370.12345@hadrien>
Date: Sat, 22 Mar 2025 15:58:43 +0100 (CET)
From: Julia Lawall <julia.lawall@...ia.fr>
To: Samuel Abraham <abrahamadekunle50@...il.com>
cc: outreachy@...ts.linux.dev, gregkh@...uxfoundation.org, 
    linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: bcm2835-camera: Modify function call
 formatting



On Sat, 22 Mar 2025, Samuel Abraham wrote:

> On Sat, Mar 22, 2025 at 3:11 PM Julia Lawall <julia.lawall@...ia.fr> wrote:
> >
> >
> >
> > On Sat, 22 Mar 2025, Abraham Samuel Adekunle wrote:
> >
> > > The line is a function call which ends with an opening parenthesis
> > > thereby not adhering to the Linux kernel coding style.
> > >
> > > Modify the function call to include parameters on the same line as
> > > the opening parenthesis to improve readability and consistency while
> > > adhering to Linux coding styles.
> > >
> > > Reported by checkpatch:
> > >
> > > CHECK: Lines should not end with '('
> >
> > Please check the get_maintainer script (see tutorial).  It looks like
> > there are some other people who should receive patches on this driver.
> >
> > julia
> >
> Thank you very much for your review.
>
> Please just to be sure, do I include the emails of the people I
> initially sent the patch to or
> I should only send the patch again to the other people I did not
> include initially?

Send it toeveryone (ald recipients and new ones).  You should write [PATCH
v2] instead of [PATCH].  Below the --- you can write v2: and an
explanation of what has changed, ie adding more recipients.

julia