linux-kernel - Re: [PATCH] wifi: mt76: mt7996: avoid potential null deref in mt7996_get_et

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92d1a410788c54facedec033474046dda6a1a2cc.camel@sipsolutions.net>
Date: Sat, 22 Mar 2025 16:54:41 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Markus Elfring <Markus.Elfring@....de>, Qasim Ijaz <qasdev00@...il.com>,
 	linux-wireless@...r.kernel.org, linux-mediatek@...ts.infradead.org, 
	linux-arm-kernel@...ts.infradead.org
Cc: LKML <linux-kernel@...r.kernel.org>, Angelo Gioacchino Del Regno	
 <angelogioacchino.delregno@...labora.com>, Bo Jiao <bo.jiao@...iatek.com>, 
 Dan Carpenter <dan.carpenter@...aro.org>, Felix Fietkau <nbd@....name>,
 Lorenzo Bianconi <lorenzo@...nel.org>,  Matthias Brugger
 <matthias.bgg@...il.com>, Peter Chiu <chui-hao.chiu@...iatek.com>, Ryder
 Lee <ryder.lee@...iatek.com>,  Sean Wang <sean.wang@...iatek.com>, Shayne
 Chen <shayne.chen@...iatek.com>
Subject: Re: [PATCH] wifi: mt76: mt7996: avoid potential null deref in
 mt7996_get_et_stats()

On Sat, 2025-03-22 at 15:55 +0100, Markus Elfring wrote:
> > Ensure phy->mib is only accessed after the null sanity check for phy
> > otherwise the code may trigger a potential null deref.
> 
> * Would you like to use the term “null pointer dereference” consistently?
> 
> * Were any known source code analysis tools involved also for
>   this software improvement?
> 

Do you really have to double down? STOP. You're just wasting everyone's
time.

johannes