linux-kernel - Re: [PATCH v5 01/17] rust: enable `raw_ref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ-ks9=GHVfd=iRT73DviOD=6dio3U7wQWLaXAhKr3UG5-ivvw@mail.gmail.com>
Date: Sat, 22 Mar 2025 14:24:30 -0400
From: Tamir Duberstein <tamird@...il.com>
To: Antonio Hickey <contact@...oniohickey.com>
Cc: benno.lossin@...ton.me, a.hindborg@...nel.org, alex.gaynor@...il.com, 
	aliceryhl@...gle.com, bjorn3_gh@...tonmail.com, boqun.feng@...il.com, 
	dakr@...nel.org, gary@...yguo.net, linux-kbuild@...r.kernel.org, 
	linux-kernel@...r.kernel.org, masahiroy@...nel.org, nathan@...nel.org, 
	nicolas@...sle.eu, ojeda@...nel.org, rust-for-linux@...r.kernel.org, 
	tmgross@...ch.edu
Subject: Re: [PATCH v5 01/17] rust: enable `raw_ref_op` feature

On Sat, Mar 22, 2025 at 11:08 AM Antonio Hickey
<contact@...oniohickey.com> wrote:
>
> On Sat, Mar 22, 2025 at 10:16:01AM +0000, Benno Lossin wrote:
> > On Thu Mar 20, 2025 at 3:07 AM CET, Antonio Hickey wrote:
> > > Since Rust 1.82.0 the `raw_ref_op` feature is stable.
> > >
> > > By enabling this feature we can use `&raw const place` and
> > > `&raw mut place` instead of using `addr_of!(place)` and
> > > `addr_of_mut!(place)` macros.
> > >
> > > Allowing us to reduce macro complexity, and improve consistency
> > > with existing reference syntax as `&raw const`, `&raw mut` are
> > > similar to `&`, `&mut` making it fit more naturally with other
> > > existing code.
> > >
> > > Suggested-by: Benno Lossin <benno.lossin@...ton.me>
> > > Link: https://github.com/Rust-for-Linux/linux/issues/1148
> > > Signed-off-by: Antonio Hickey <contact@...oniohickey.com>
> >
> > Reviewed-by: Benno Lossin <benno.lossin@...ton.me>
> >
> > > diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> > > index 993708d11874..a73aaa028e34 100644
> > > --- a/scripts/Makefile.build
> > > +++ b/scripts/Makefile.build
> > > @@ -224,9 +224,9 @@ $(obj)/%.lst: $(obj)/%.c FORCE
> > >     $(call if_changed_dep,cc_lst_c)
> > >
> > >  # Compile Rust sources (.rs)
> > > -# ---------------------------------------------------------------------------
> > > +# --------------------------------------------------------------------------------------
> >
> > Not sure about this change.
>
> This change is so I could enable the `raw_ref_op` feature for doctests
> since the minimum Rust version 1.78 still has `raw_ref_op` as an
> expiramental feature, and will throw errors at compile if a doctest uses
> it. Is there a better way to do this?

I think Benno is just asking about the extension of the dashed line.

> > >
> > > -rust_allowed_features := asm_const,asm_goto,arbitrary_self_types,lint_reasons
> > > +rust_allowed_features := asm_const,asm_goto,arbitrary_self_types,lint_reasons,raw_ref_op

This looks correct to me.

> > >
> > >  # `--out-dir` is required to avoid temporaries being created by `rustc` in the
> > >  # current working directory, which may be not accessible in the out-of-tree
> >
> >

Reviewed-by: Tamir Duberstein <tamird@...il.com>