linux-kernel - Re: [PATCH v2 -next] media: cec: tda9950: Add missing I2C dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f3b1d3c9-d959-4096-8ee6-fd08a088d602@huawei.com>
Date: Sat, 22 Mar 2025 11:40:47 +0800
From: Yue Haibing <yuehaibing@...wei.com>
To: <hverkuil@...all.nl>, <mchehab@...nel.org>, <lumag@...nel.org>,
	<dmitry.baryshkov@...aro.org>
CC: <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<dri-devel@...ts.freedesktop.org>, <maarten.lankhorst@...ux.intel.com>,
	<mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
	<airlied@...il.com>
Subject: Re: [PATCH v2 -next] media: cec: tda9950: Add missing I2C dependency

On 2025/3/22 10:49, Yue Haibing wrote:
> If CONFIG_I2C is not set, build fails:
> 
> drivers/media/cec/i2c/tda9950.c: In function ‘tda9950_probe’:
> drivers/media/cec/i2c/tda9950.c:391:14: error: implicit declaration of function ‘i2c_check_functionality’ [-Werror=implicit-function-declaration]
> 	if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
>       |              ^~~~~~~~~~~~~~~~~~~~~~~
>   CC      crypto/aes_generic.o
> drivers/media/cec/i2c/tda9950.c: At top level:
> drivers/media/cec/i2c/tda9950.c:503:1: warning: data definition has no type or storage class
>   503 | module_i2c_driver(tda9950_driver);
>       | ^~~~~~~~~~~~~~~~~
> drivers/media/cec/i2c/tda9950.c:503:1: error: type defaults to ‘int’ in declaration of ‘module_i2c_driver’ [-Werror=implicit-int]
> drivers/media/cec/i2c/tda9950.c:503:1: warning: parameter names (without types) in function declaration
> 
> Add missing I2C dependency to fix this.
> 
> Fixes: caa6f4a75e9f ("media: cec: move driver for TDA9950 from drm/i2c")

Just FYI,
commit caa6f4a75e9f has only applied to drm-misc-next, so also cc drm drivers maintainer

> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
> ---
> v2: Fix patch title, also cc dri-devel list
> ---
>  drivers/media/cec/i2c/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/cec/i2c/Kconfig b/drivers/media/cec/i2c/Kconfig
> index b9d21643eef1..c31abc26f602 100644
> --- a/drivers/media/cec/i2c/Kconfig
> +++ b/drivers/media/cec/i2c/Kconfig
> @@ -16,6 +16,7 @@ config CEC_CH7322
>  
>  config CEC_NXP_TDA9950
>  	tristate "NXP Semiconductors TDA9950/TDA998X HDMI CEC"
> +	depends on I2C
>  	select CEC_NOTIFIER
>  	select CEC_CORE
>  	default DRM_I2C_NXP_TDA998X