[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250322203558.206411-1-jdamato@fastly.com>
Date: Sat, 22 Mar 2025 20:35:43 +0000
From: Joe Damato <jdamato@...tly.com>
To: linux-fsdevel@...r.kernel.org
Cc: netdev@...r.kernel.org,
brauner@...nel.org,
asml.silence@...il.com,
hch@...radead.org,
axboe@...nel.dk,
edumazet@...gle.com,
kuba@...nel.org,
pabeni@...hat.com,
horms@...nel.org,
Joe Damato <jdamato@...tly.com>,
Alexander Viro <viro@...iv.linux.org.uk>,
"David S. Miller" <davem@...emloft.net>,
Jan Kara <jack@...e.cz>,
linux-kernel@...r.kernel.org (open list)
Subject: [PATCH vfs/for-next 0/3] Move splice_to_socket to net/socket.c
Greetings:
While reading through the splice and socket code I noticed that some
splice helpers (like sock_splice_read and sock_splice_eof) live in
net/socket.c, but splice_to_socket does not.
I am not sure if there is a reason for this, but it seems like moving
this code provides some advantages:
- Eliminates the #ifdef CONFIG_NET from fs/splice.c
- Keeps the socket related splice helpers together in net/socket.c
where it seems (IMHO) more logical for them to live
This change is essentially cleanup; no functional changes to splice are
introduced.
I based this change on vfs/for-next since 2 of the 3 patches are vfs,
but I am happy to rebase this on another tree if necessary.
Thanks,
Joe
Joe Damato (3):
pipe: Move pipe wakeup helpers out of splice
splice: Move splice_to_socket to net/socket.c
net: splice_to_socket: RCT declaration cleanup
fs/pipe.c | 16 ++++
fs/splice.c | 170 ++------------------------------------
include/linux/pipe_fs_i.h | 4 +
include/linux/splice.h | 3 -
net/socket.c | 140 +++++++++++++++++++++++++++++++
5 files changed, 167 insertions(+), 166 deletions(-)
base-commit: 2e72b1e0aac24a12f3bf3eec620efaca7ab7d4de
--
2.43.0
Powered by blists - more mailing lists