linux-kernel - Re: [PATCH v11 5/8] rust: time: Add wrapper for fsleep() function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a59db1h2.fsf@kernel.org>
Date: Sat, 22 Mar 2025 15:10:17 +0100
From: Andreas Hindborg <a.hindborg@...nel.org>
To: FUJITA Tomonori <fujita.tomonori@...il.com>
Cc: linux-kernel@...r.kernel.org,  Daniel Almeida
 <daniel.almeida@...labora.com>,  Gary Guo <gary@...yguo.net>,  Alice Ryhl
 <aliceryhl@...gle.com>,  Fiona Behrens <me@...enk.dev>,
  rust-for-linux@...r.kernel.org,  netdev@...r.kernel.org,  andrew@...n.ch,
  hkallweit1@...il.com,  tmgross@...ch.edu,  ojeda@...nel.org,
  alex.gaynor@...il.com,  bjorn3_gh@...tonmail.com,
  benno.lossin@...ton.me,  a.hindborg@...sung.com,
  anna-maria@...utronix.de,  frederic@...nel.org,  tglx@...utronix.de,
  arnd@...db.de,  jstultz@...gle.com,  sboyd@...nel.org,  mingo@...hat.com,
  peterz@...radead.org,  juri.lelli@...hat.com,
  vincent.guittot@...aro.org,  dietmar.eggemann@....com,
  rostedt@...dmis.org,  bsegall@...gle.com,  mgorman@...e.de,
  vschneid@...hat.com,  tgunders@...hat.com,  david.laight.linux@...il.com
Subject: Re: [PATCH v11 5/8] rust: time: Add wrapper for fsleep() function

FUJITA Tomonori <fujita.tomonori@...il.com> writes:

> Add a wrapper for fsleep(), flexible sleep functions in
> include/linux/delay.h which typically deals with hardware delays.
>
> The kernel supports several sleep functions to handle various lengths
> of delay. This adds fsleep(), automatically chooses the best sleep
> method based on a duration.
>
> sleep functions including fsleep() belongs to TIMERS, not
> TIMEKEEPING. They are maintained separately. rust/kernel/time.rs is an
> abstraction for TIMEKEEPING. To make Rust abstractions match the C
> side, add rust/kernel/time/delay.rs for this wrapper.
>
> fsleep() can only be used in a nonatomic context. This requirement is
> not checked by these abstractions, but it is intended that klint [1]
> or a similar tool will be used to check it in the future.
>
> Link: https://rust-for-linux.com/klint [1]
> Tested-by: Daniel Almeida <daniel.almeida@...labora.com>
> Reviewed-by: Gary Guo <gary@...yguo.net>
> Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>
> Reviewed-by: Fiona Behrens <me@...enk.dev>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@...il.com>

Reviewed-by: Andreas Hindborg <a.hindborg@...nel.org>


Best regards,
Andreas Hindborg