| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202503231053.WFt2cPIR-lkp@intel.com>
Date: Sun, 23 Mar 2025 10:20:04 +0800
From: kernel test robot <lkp@...el.com>
To: nancyenos <nicymimz@...il.com>,
"outreachy @ lists . linux . dev Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
nancyenos <nicymimz@...il.com>
Subject: Re: [PATCH] staging: octeon: Fix unused macro Argument 'x'
Hi nancyenos,
kernel test robot noticed the following build errors:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/nancyenos/staging-octeon-Fix-unused-macro-Argument-x/20250322-084136
base: staging/staging-testing
patch link: https://lore.kernel.org/r/20250322003218.14134-1-nicymimz%40gmail.com
patch subject: [PATCH] staging: octeon: Fix unused macro Argument 'x'
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20250323/202503231053.WFt2cPIR-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250323/202503231053.WFt2cPIR-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503231053.WFt2cPIR-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/staging/octeon/ethernet.c:258:23: error: use of undeclared identifier 'OCTEON_CN3XXX'
258 | if (OCTEON_IS_MODEL(OCTEON_CN3XXX) ||
| ^
>> drivers/staging/octeon/ethernet.c:259:23: error: use of undeclared identifier 'OCTEON_CN58XX'
259 | OCTEON_IS_MODEL(OCTEON_CN58XX)) {
| ^
>> drivers/staging/octeon/ethernet.c:469:25: error: use of undeclared identifier 'OCTEON_FEATURE_PKND'
469 | if (octeon_has_feature(OCTEON_FEATURE_PKND))
| ^
>> drivers/staging/octeon/ethernet.c:725:25: error: use of undeclared identifier 'OCTEON_CN68XX'
725 | if (OCTEON_IS_MODEL(OCTEON_CN68XX))
| ^
4 errors generated.
--
>> drivers/staging/octeon/ethernet-rx.c:67:25: error: use of undeclared identifier 'OCTEON_FEATURE_PKND'
67 | if (octeon_has_feature(OCTEON_FEATURE_PKND))
| ^
>> drivers/staging/octeon/ethernet-rx.c:201:22: error: use of undeclared identifier 'OCTEON_CN68XX'
201 | if (OCTEON_IS_MODEL(OCTEON_CN68XX)) {
| ^
drivers/staging/octeon/ethernet-rx.c:233:24: error: use of undeclared identifier 'OCTEON_CN68XX'
233 | if (OCTEON_IS_MODEL(OCTEON_CN68XX)) {
| ^
drivers/staging/octeon/ethernet-rx.c:267:26: error: use of undeclared identifier 'OCTEON_FEATURE_PKND'
267 | if (octeon_has_feature(OCTEON_FEATURE_PKND))
| ^
drivers/staging/octeon/ethernet-rx.c:389:22: error: use of undeclared identifier 'OCTEON_CN68XX'
389 | if (OCTEON_IS_MODEL(OCTEON_CN68XX)) {
| ^
drivers/staging/octeon/ethernet-rx.c:489:23: error: use of undeclared identifier 'OCTEON_CN68XX'
489 | if (OCTEON_IS_MODEL(OCTEON_CN68XX)) {
| ^
drivers/staging/octeon/ethernet-rx.c:532:23: error: use of undeclared identifier 'OCTEON_CN68XX'
532 | if (OCTEON_IS_MODEL(OCTEON_CN68XX))
| ^
7 errors generated.
--
>> drivers/staging/octeon/ethernet-tx.c:227:41: error: use of undeclared identifier 'OCTEON_CN3XXX'
227 | if ((skb->len < 64) && OCTEON_IS_MODEL(OCTEON_CN3XXX)) {
| ^
>> drivers/staging/octeon/ethernet-tx.c:558:23: error: use of undeclared identifier 'OCTEON_CN68XX'
558 | if (!OCTEON_IS_MODEL(OCTEON_CN68XX))
| ^
2 errors generated.
vim +/OCTEON_CN3XXX +258 drivers/staging/octeon/ethernet.c
422d97b8b05ed3 Chris Packham 2020-02-05 230
422d97b8b05ed3 Chris Packham 2020-02-05 231 /**
422d97b8b05ed3 Chris Packham 2020-02-05 232 * cvm_oct_common_change_mtu - change the link MTU
422d97b8b05ed3 Chris Packham 2020-02-05 233 * @dev: Device to change
422d97b8b05ed3 Chris Packham 2020-02-05 234 * @new_mtu: The new MTU
422d97b8b05ed3 Chris Packham 2020-02-05 235 *
422d97b8b05ed3 Chris Packham 2020-02-05 236 * Returns Zero on success
422d97b8b05ed3 Chris Packham 2020-02-05 237 */
422d97b8b05ed3 Chris Packham 2020-02-05 238 static int cvm_oct_common_change_mtu(struct net_device *dev, int new_mtu)
422d97b8b05ed3 Chris Packham 2020-02-05 239 {
422d97b8b05ed3 Chris Packham 2020-02-05 240 struct octeon_ethernet *priv = netdev_priv(dev);
422d97b8b05ed3 Chris Packham 2020-02-05 241 int interface = INTERFACE(priv->port);
422d97b8b05ed3 Chris Packham 2020-02-05 242 #if IS_ENABLED(CONFIG_VLAN_8021Q)
422d97b8b05ed3 Chris Packham 2020-02-05 243 int vlan_bytes = VLAN_HLEN;
422d97b8b05ed3 Chris Packham 2020-02-05 244 #else
422d97b8b05ed3 Chris Packham 2020-02-05 245 int vlan_bytes = 0;
422d97b8b05ed3 Chris Packham 2020-02-05 246 #endif
422d97b8b05ed3 Chris Packham 2020-02-05 247 int mtu_overhead = ETH_HLEN + ETH_FCS_LEN + vlan_bytes;
422d97b8b05ed3 Chris Packham 2020-02-05 248
422d97b8b05ed3 Chris Packham 2020-02-05 249 dev->mtu = new_mtu;
422d97b8b05ed3 Chris Packham 2020-02-05 250
422d97b8b05ed3 Chris Packham 2020-02-05 251 if ((interface < 2) &&
422d97b8b05ed3 Chris Packham 2020-02-05 252 (cvmx_helper_interface_get_mode(interface) !=
422d97b8b05ed3 Chris Packham 2020-02-05 253 CVMX_HELPER_INTERFACE_MODE_SPI)) {
422d97b8b05ed3 Chris Packham 2020-02-05 254 int index = INDEX(priv->port);
422d97b8b05ed3 Chris Packham 2020-02-05 255 /* Add ethernet header and FCS, and VLAN if configured. */
422d97b8b05ed3 Chris Packham 2020-02-05 256 int max_packet = new_mtu + mtu_overhead;
422d97b8b05ed3 Chris Packham 2020-02-05 257
422d97b8b05ed3 Chris Packham 2020-02-05 @258 if (OCTEON_IS_MODEL(OCTEON_CN3XXX) ||
422d97b8b05ed3 Chris Packham 2020-02-05 @259 OCTEON_IS_MODEL(OCTEON_CN58XX)) {
422d97b8b05ed3 Chris Packham 2020-02-05 260 /* Signal errors on packets larger than the MTU */
422d97b8b05ed3 Chris Packham 2020-02-05 261 cvmx_write_csr(CVMX_GMXX_RXX_FRM_MAX(index, interface),
422d97b8b05ed3 Chris Packham 2020-02-05 262 max_packet);
422d97b8b05ed3 Chris Packham 2020-02-05 263 } else {
422d97b8b05ed3 Chris Packham 2020-02-05 264 /*
422d97b8b05ed3 Chris Packham 2020-02-05 265 * Set the hardware to truncate packets larger
422d97b8b05ed3 Chris Packham 2020-02-05 266 * than the MTU and smaller the 64 bytes.
422d97b8b05ed3 Chris Packham 2020-02-05 267 */
422d97b8b05ed3 Chris Packham 2020-02-05 268 union cvmx_pip_frm_len_chkx frm_len_chk;
422d97b8b05ed3 Chris Packham 2020-02-05 269
422d97b8b05ed3 Chris Packham 2020-02-05 270 frm_len_chk.u64 = 0;
422d97b8b05ed3 Chris Packham 2020-02-05 271 frm_len_chk.s.minlen = VLAN_ETH_ZLEN;
422d97b8b05ed3 Chris Packham 2020-02-05 272 frm_len_chk.s.maxlen = max_packet;
422d97b8b05ed3 Chris Packham 2020-02-05 273 cvmx_write_csr(CVMX_PIP_FRM_LEN_CHKX(interface),
422d97b8b05ed3 Chris Packham 2020-02-05 274 frm_len_chk.u64);
422d97b8b05ed3 Chris Packham 2020-02-05 275 }
422d97b8b05ed3 Chris Packham 2020-02-05 276 /*
422d97b8b05ed3 Chris Packham 2020-02-05 277 * Set the hardware to truncate packets larger than
422d97b8b05ed3 Chris Packham 2020-02-05 278 * the MTU. The jabber register must be set to a
422d97b8b05ed3 Chris Packham 2020-02-05 279 * multiple of 8 bytes, so round up.
422d97b8b05ed3 Chris Packham 2020-02-05 280 */
422d97b8b05ed3 Chris Packham 2020-02-05 281 cvmx_write_csr(CVMX_GMXX_RXX_JABBER(index, interface),
422d97b8b05ed3 Chris Packham 2020-02-05 282 (max_packet + 7) & ~7u);
422d97b8b05ed3 Chris Packham 2020-02-05 283 }
422d97b8b05ed3 Chris Packham 2020-02-05 284 return 0;
422d97b8b05ed3 Chris Packham 2020-02-05 285 }
422d97b8b05ed3 Chris Packham 2020-02-05 286
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists