linux-kernel - Re: [PATCH] 9p: Use hashtable.h for hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2699178.Jt51f5JuzZ@silver>
Date: Sun, 23 Mar 2025 14:05:21 +0100
From: Christian Schoenebeck <linux_oss@...debyte.com>
To: Sasha Levin <sashal@...nel.org>, asmadeus@...ewreck.org
Cc: ericvh@...nel.org, lucho@...kov.net, v9fs@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] 9p: Use hashtable.h for hash_errmap

On Saturday, March 22, 2025 10:26:20 PM CET asmadeus@...ewreck.org wrote:
> Sasha Levin wrote on Thu, Mar 20, 2025 at 10:52:00AM -0400:
> > Convert hash_errmap in error.c to use the generic hashtable
> > implementation from hashtable.h instead of the manual hlist_head array
> > implementation.
> > 
> > This simplifies the code and makes it more maintainable by using the
> > standard hashtable API and removes the need for manual hash table
> > management.
> 
> I'm not entierly convinced this is simpler from my little island (that's
> one more API to learn about vs code that doesn't look all that
> different), but I guess I can see the point from an overall perspective.
> 
> I see no problem with this, I'll pick it up for -next
> Note this code is not used for 9p2000l iirc so I currently don't have
> any test for it :/
> (but it's simple enough that I'm willing to take the risk)

Correct, that code is only used for legacy 9p2000 and 9p2000.u protocol
versions, but not for the default 9p2000.L version which is transmitting
numeric (Linux) error codes only (i.e. error strings are never transmitted
with 9p2000.L, hence no translation via hash map needed).

/Christian