linux-kernel - Re: [PATCH] rust: sync: optimize rust symbol generation for CondVar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-BGm3zBEGazp5gb@Mac.home>
Date: Sun, 23 Mar 2025 10:36:27 -0700
From: Boqun Feng <boqun.feng@...il.com>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Kunwu Chan <kunwu.chan@...ux.dev>, ojeda@...nel.org,
	alex.gaynor@...il.com, gary@...yguo.net, bjorn3_gh@...tonmail.com,
	benno.lossin@...ton.me, a.hindborg@...nel.org, tmgross@...ch.edu,
	dakr@...nel.org, nathan@...nel.org, nick.desaulniers+lkml@...il.com,
	morbo@...gle.com, justinstitt@...gle.com,
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
	llvm@...ts.linux.dev, Kunwu Chan <kunwu.chan@...mail.com>,
	Grace Deng <Grace.Deng006@...il.com>
Subject: Re: [PATCH] rust: sync: optimize rust symbol generation for CondVar

On Mon, Mar 17, 2025 at 10:29:17AM +0000, Alice Ryhl wrote:
> On Mon, Mar 17, 2025 at 04:13:50PM +0800, Kunwu Chan wrote:
> > From: Kunwu Chan <kunwu.chan@...mail.com>
> > 
> > When build the kernel using the llvm-18.1.3-rust-1.85.0-x86_64
> > with ARCH=arm64, the following symbols are generated:
> > 
> > $nm vmlinux | grep ' _R'.*CondVar | rustfilt
> > ... T <kernel::sync::condvar::CondVar>::notify_all
> > ... T <kernel::sync::condvar::CondVar>::notify_one
> > ... T <kernel::sync::condvar::CondVar>::notify_sync
> > ... T <kernel::sync::condvar::CondVar>::new::{closure#0}::{closure#0}::panic_cold_explicit
> > ... T <kernel::sync::condvar::CondVar>::new::{closure#0}::{closure#0}::panic_cold_explicit
> > ... T <kernel::sync::poll::PollCondVar>::new::{closure#0}::{closure#0}::panic_cold_explicit
> > ... T <kernel::sync::poll::PollCondVar as core::ops::drop::Drop>::drop
> > 
> > These notify* symbols are trivial wrappers around the C functions
> > __wake_up and __wake_up_sync.
> > It doesn't make sense to go through a trivial wrapper for these
> > functions, so mark them inline.
> 
> You don't need to send a new version just for this, but please format
> the paragraphs better in the future. For example:
> 
> The notify* symbols are trivial wrappers around the C functions
> __wake_up and __wake_up_sync. It doesn't make sense to go through a
> trivial wrapper for these functions, so mark them inline.
> 
> > Link: https://github.com/Rust-for-Linux/linux/issues/1145
> > Suggested-by: Alice Ryhl <aliceryhl@...gle.com>
> > Co-developed-by: Grace Deng <Grace.Deng006@...il.com>
> > Signed-off-by: Grace Deng <Grace.Deng006@...il.com>
> > Signed-off-by: Kunwu Chan <kunwu.chan@...mail.com>
> 
> Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>
> 

Queued for future tests and reviews, thank you all.

Regards,
Boqun