linux-kernel - Re: [PATCH 13/13] objtool: Add CONFIG_OBJTOOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <smpvowgf5xzatcat3gwpaxf3nvoacfyv4bbry545tjyxpx7dv2@bjurc4a4kn3l>
Date: Sun, 23 Mar 2025 00:50:34 -0700
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: Miroslav Benes <mbenes@...e.cz>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org, 
	Peter Zijlstra <peterz@...radead.org>, Brendan Jackman <jackmanb@...gle.com>, 
	Nathan Chancellor <nathan@...nel.org>
Subject: Re: [PATCH 13/13] objtool: Add CONFIG_OBJTOOL_WERROR

On Mon, Mar 17, 2025 at 03:14:25PM +0100, Miroslav Benes wrote:
> On Fri, 14 Mar 2025, Josh Poimboeuf wrote:
> 
> > Objtool warnings can be indicative of crashes, broken live patching, or
> > even boot failures.  Ignoring them is not recommended.
> > 
> > Add CONFIG_OBJTOOL_WERROR to upgrade objtool warnings to errors by
> > enabling the objtool --Werror option.  Also set --backtrace to print the
> > branches leading up to the warning, which can help considerably when
> > debugging certain warnings.
> > 
> > To avoid breaking bots too badly for now, make it the default for real
> > world builds only (!COMPILE_TEST).
> > 
> > Co-developed-by: Brendan Jackman <jackmanb@...gle.com>
> > Signed-off-by: Josh Poimboeuf <jpoimboe@...nel.org>
> 
> Brendan's SoB missing.
> 
> With 'default y' being present or not
> 
> Reviewed-by: Miroslav Benes <mbenes@...e.cz>

Miroslav and Brendan, thanks for the reviews.

This was merged with a quickness, so I wasn't able to post a v2 to
update the commit logs.  However I will be posting some patches soon to
address the other comments, along with a bunch of fixes.

-- 
Josh