linux-kernel - Re: [PATCH] rust: print: add rustdoc link to std::format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D8NKOYBU4B7C.2QEMXLVBOZK9U@proton.me>
Date: Sun, 23 Mar 2025 10:27:59 +0000
From: Benno Lossin <benno.lossin@...ton.me>
To: Andrew Ballance <andrewjballance@...il.com>, ojeda@...nel.org, boqun.feng@...il.com, gary@...yguo.net, bjorn3_gh@...tonmail.com, a.hindborg@...nel.org, aliceryhl@...gle.com, tmgross@...ch.edu, rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: alex.gaynor@...il.com, jubalh@...oru.org
Subject: Re: [PATCH] rust: print: add rustdoc link to std::format

On Sun Mar 23, 2025 at 6:59 AM CET, Andrew Ballance wrote:
> Adds a url link to the rust std's format! to the pr_* macro docs.
>
> Additionally replaces refrences to alloc::format[1] with std::format[2]
> because they are identical but less likely to cause confusion with the
> kernel's alloc crate.
>
> Link: https://doc.rust-lang.org/alloc/macro.format.html [1]
> Link: https://doc.rust-lang.org/std/macro.format.html [2]
> Signed-off-by: Andrew Ballance <andrewjballance@...il.com>
> ---
>  rust/kernel/print.rs | 27 ++++++++++++++++++---------
>  1 file changed, 18 insertions(+), 9 deletions(-)

There are also instances of `alloc::format!` in `rust/kernel/device.rs`.
Could you also add those? Thanks!

Reviewed-by: Benno Lossin <benno.lossin@...ton.me>

---
Cheers,
Benno