linux-kernel - RE: [EXT] Re: [PATCH v4 2/2] wifi: mwifiex: Fix RF calibration data download from file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAWPR04MB9910B875495307CD3FC0BD1D9CA42@PAWPR04MB9910.eurprd04.prod.outlook.com>
Date: Mon, 24 Mar 2025 16:47:34 +0000
From: Jeff Chen <jeff.chen_1@....com>
To: Francesco Dolcini <francesco@...cini.it>
CC: "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"briannorris@...omium.org" <briannorris@...omium.org>,
	"johannes@...solutions.net" <johannes@...solutions.net>, Pete Hsieh
	<tsung-hsien.hsieh@....com>, "s.hauer@...gutronix.de"
	<s.hauer@...gutronix.de>
Subject: RE: [EXT] Re: [PATCH v4 2/2] wifi: mwifiex: Fix RF calibration data
 download from file

> Hello Jeff,
> 
> On Tue, Mar 18, 2025 at 01:07:39PM +0800, Jeff Chen wrote:
> > While this patch restores the ability to download RF calibration data
> > from a file, it may inadvertently break the feature to download
> > calibration data from the device tree.
> 
> I do not think this is acceptable. Fixing something by adding another bug is not
> ok. You should fix the calibration data from file, without breaking the device
> tree calibration functionality.
> 
> Francesco

Hello Francesco,  


There seems to be a misunderstanding. The issue with breaking the device tree
calibration functionality was actually introduced in version 3 of the patch. Version 4
resolves this problem by ensuring that both file-based and device tree-based
calibration work as intended.  

The current patch restores the ability to download RF calibration data from a file 
without affecting the device tree functionality. I'll clarify this in the commit message
to avoid further confusion.  

Best regards,  
Jeff