linux-kernel - Re: [PATCH v2 net-next] rndis_host: Flag RNDIS modems as WWAN devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250324112611.0eb6fdc3@kernel.org>
Date: Mon, 24 Mar 2025 11:26:11 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Lubomir Rintel <lkundrak@...sk>
Cc: linux-usb@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org, Eric Dumazet
 <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>, Andrew Lunn
 <andrew+netdev@...n.ch>
Subject: Re: [PATCH v2 net-next] rndis_host: Flag RNDIS modems as WWAN
 devices

On Mon, 17 Mar 2025 16:07:37 +0100 Lubomir Rintel wrote:
> Set FLAG_WWAN instead of FLAG_ETHERNET for RNDIS interfaces on Mobile
> Broadband Modems, as opposed to regular Ethernet adapters.
> 
> Otherwise NetworkManager gets confused, misjudges the device type,
> and wouldn't know it should connect a modem to get the device to work.
> What would be the result depends on ModemManager version -- older
> ModemManager would end up disconnecting a device after an unsuccessful
> probe attempt (if it connected without needing to unlock a SIM), while
> a newer one might spawn a separate PPP connection over a tty interface
> instead, resulting in a general confusion and no end of chaos.
> 
> The only way to get this work reliably is to fix the device type
> and have good enough version ModemManager (or equivalent).
> 
> Signed-off-by: Lubomir Rintel <lkundrak@...sk>
> Fixes: 475ddf05ce2d ("rndis_host: Flag RNDIS modems as WWAN devices")

This should point to the commit you're fixing. Judging purely by the
touched lines perhaps 63ba395cd7a5 ("rndis_host: support Novatel Verizon
USB730L") ?
-- 
pw-bot: cr