linux-kernel - Re: [PATCH] kunit: cs_dsp: Depend on FW_CS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA1CXcCsYAdAaO-C=2f9PGdYCNgBYjdz=wjE9KdG-8xTkCrB5w@mail.gmail.com>
Date: Mon, 24 Mar 2025 12:31:48 -0600
From: Nico Pache <npache@...hat.com>
To: Mark Brown <broonie@...nel.org>
Cc: rf@...nsource.cirrus.com, patches@...nsource.cirrus.com, 
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	kunit-dev@...glegroups.com, simont@...nsource.cirrus.com, 
	ckeepax@...nsource.cirrus.com, brendan.higgins@...ux.dev, davidgow@...gle.com, 
	rmoar@...gle.com, johannes.berg@...el.com, sj@...nel.org
Subject: Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

On Fri, Mar 21, 2025 at 9:51 AM Mark Brown <broonie@...nel.org> wrote:
>
> On Fri, Mar 21, 2025 at 09:01:35AM -0600, Nico Pache wrote:
> > On Fri, Mar 21, 2025 at 8:51 AM Mark Brown <broonie@...nel.org> wrote:
>
> > > That user select should only be visible if KUnit is enabled though,
> > > it really is library code so shouldn't actually be user selectable.  I'm
> > > not sure if there's some other strategy other KUnit tests for libraries
> > > use.
>
> > I'm a little confused how the FW_CS_DSP config which was added in
> > v5.16 is reliant (library code that is only used by KUNIT) on a config
> > that was added in v6.14. Presumably the library is not just for the
> > KUNIT test. What was the purpose of this config before the
> > introduction of the KUNIT test. Im guessing it was not user selectable
> > back then too.
>
> This is support code for DSPs that Cirrus have in some of their devices,
> the drivers for devices that have these DSPs select it - a git grep will
> show the selects.

Ah ok I see! I'm not sure what the 'proper' KUNIT behavior is for this
config case. But I'll trust your judgement and expertise, we can
probably leave this as is for now.

Cheers,
-- Nico