linux-kernel - Re: [PATCH 3/5] dt-bindings: iio: adc: add ad7405 axi variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cfec0b2d-cbdd-4b64-8fea-2676e7dbc1f1@baylibre.com>
Date: Mon, 24 Mar 2025 13:55:38 -0500
From: David Lechner <dlechner@...libre.com>
To: Pop Ioan Daniel <pop.ioan-daniel@...log.com>,
 Lars-Peter Clausen <lars@...afoo.de>,
 Michael Hennerich <Michael.Hennerich@...log.com>,
 Jonathan Cameron <jic23@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Nuno Sa <nuno.sa@...log.com>,
 Olivier Moysan <olivier.moysan@...s.st.com>,
 Javier Carrasco <javier.carrasco.cruz@...il.com>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Trevor Gamblin <tgamblin@...libre.com>, Guillaume Stols
 <gstols@...libre.com>, Dumitru Ceclan <mitrutzceclan@...il.com>,
 Matteo Martelli <matteomartelli3@...il.com>,
 Marcelo Schmitt <marcelo.schmitt@...log.com>,
 Alisa-Dariana Roman <alisadariana@...il.com>,
 Thomas Bonnefille <thomas.bonnefille@...tlin.com>,
 Ramona Alexandra Nechita <ramona.nechita@...log.com>,
 Dragos Bogdan <dragos.bogdan@...log.com>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] dt-bindings: iio: adc: add ad7405 axi variant

On 3/24/25 4:07 AM, Pop Ioan Daniel wrote:
> Add a new compatible and related bindings for the fpga-based ad7405 AXI

It's just a new compatible string. There don't seem to be any other related
bindings. So we don't need to say that in the description. 

And typically, FGPA is written in all caps.

> IP core, a variant of the generic AXI ADC IP.
> 
> The AXI AD7405 IP is a very similar HDL (fpga) variant of the generic
> AXI ADC IP, intended to control ad7405/adum770x family.

It helps the DT maintainers review if we can say specifically what the
difference is. In this case, I don't actually seen any registers that are
different from the generic AXI ADC IP block, so I'm not sure we actually need
a new compatible string in this case.

The REG_CHAN_USR_CNTRL_2 that you add in this series for the decimation rate
is documented in the generic IP block [1]. So the generic "adi,axi-adc-10.0.a"
should work. The chips that needed their own compatible have conflicting uses
for CUSTOM_CONTROL in the CNTRL_3 register, but it looks like this isn't used
for ad7405. 

[1]: https://wiki.analog.com/resources/fpga/docs/axi_adc_ip

> 
> Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@...log.com>
> ---
>  Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> index 4fa82dcf6fc9..1b02217ff8b5 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> @@ -27,6 +27,7 @@ description: |
>        the ad7606 family.
>  
>    https://wiki.analog.com/resources/fpga/docs/axi_adc_ip
> +  https://analogdevicesinc.github.io/hdl/library/axi_ad7405/index.html
>    http://analogdevicesinc.github.io/hdl/library/axi_ad7606x/index.html
>  
>  properties:
> @@ -34,6 +35,7 @@ properties:
>      enum:
>        - adi,axi-adc-10.0.a
>        - adi,axi-ad7606x
> +      - adi,axi-ad7405
>  
>    reg:
>      maxItems: 1