lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <994cb954-f3c4-4a44-800e-9303787c1be9@kernel.org>
Date: Mon, 24 Mar 2025 08:21:09 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ryan Chen <ryan_chen@...eedtech.com>
Cc: "benh@...nel.crashing.org" <benh@...nel.crashing.org>,
 "joel@....id.au" <joel@....id.au>,
 "andi.shyti@...nel.org" <andi.shyti@...nel.org>,
 "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
 <krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "andrew@...econstruct.com.au" <andrew@...econstruct.com.au>,
 "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
 "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>,
 "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
 "openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 Mo Elbadry <elbadrym@...gle.com>
Subject: Re: [PATCH v16 1/3] dt-bindings: i2c: aspeed: support for
 AST2600-i2cv2

On 19/03/2025 12:12, Ryan Chen wrote:
>> Subject: Re: [PATCH v16 1/3] dt-bindings: i2c: aspeed: support for
>> AST2600-i2cv2
>>
>> On 17/03/2025 10:21, Ryan Chen wrote:
>>>> Neither this.
>>>>
>>>> So it seems you describe already existing and documented I2C, but for
>>>> some reason you want second compatible. The problem is that you do
>>>> not provide reason from the point of view of bindings.
>>>>
>>>> To summarize: what your users want - don't care. Start properly
>>>> describing hardware and your SoC.
>>>
>>> OK, for ast2600 i2c controller have two register mode setting.
>>> One, I call it is old register setting, that is right now i2c-aspeed.c
>>> .compatible = "aspeed,ast2600-i2c-bus", And there have a global register
>> that can set i2c controller as new mode register set.
>>> That I am going to drive. That I post is all register in new an old register list.
>>>
>>> For example,
>>> Global register [2] = 0 => i2c present as old register set Global
>>> register [2] = 1 => i2c present as new register set
>> It's the same device though, so the same compatible.
> 
> Sorry, it is different design, and it share the same register space.
> So that the reason add new compatible "aspeed,ast2600-i2cv2" for this driver.
> It is different register layout.

Which device is described by the existing "aspeed,ast2600-i2c-bus"
compatible? And which device is described by new compatible?



Best regards,
Krzysztof

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ