linux-kernel - Re: [PATCH V6 1/2] ASoC: dt-bindings: Add cmx655 codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250324-diligent-robust-guillemot-23fb1c@krzk-bin>
Date: Mon, 24 Mar 2025 08:55:18 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Nikola Jelic <nikola.jelic83@...il.com>
Cc: lgirdwood@...il.com, broonie@...nel.org, perex@...ex.cz, 
	tiwai@...e.com, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	linux-sound@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	rwalton@...micro.com
Subject: Re: [PATCH V6 1/2] ASoC: dt-bindings: Add cmx655 codec

On Fri, Mar 21, 2025 at 11:22:47PM +0100, Nikola Jelic wrote:
> The driver is for cmx655d audio codecs from CML Micro. The CMX655D is an

This is not a driver, but binding. Drop the first sentence.

> ultra-low power voice codec targeted at digital voice and sensor
> applications.
> 
> Signed-off-by: Nikola Jelic <nikola.jelic83@...il.com>
> 
> ---

Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets.

> 
> 2025-01-25 Nikola Jelic <nikola.jelic83@...il.com> V1
>         * /Documentation/devicetree/bindings/sound/cml,cmx655d.yaml: added the device tree binding
>         * /Documentation/devicetree/bindings/sound/cmx655.txt: added the device tree description file
>         * /Documentation/devicetree/bindings/vendor-prefixes.yaml: added CML Micro, Ltd. to the vendor prefixes


>         * /sound/soc/codecs/Kconfig: added SND_SOC_CMX655D and its dependencies
>         * /sound/soc/codecs/Makefile: added snd-soc-cmx655 and its dependencies
>         * /sound/soc/codecs/cmx655.c: added the main driver file for the codec
>         * /sound/soc/codecs/cmx655.h: added the main header file for the codec
>         * /sound/soc/codecs/cmx655_i2c.c: added the i2c adapter for the codec
>         * /sound/soc/codecs/cmx655_spi.c: added the spi adapter for the codec

How are these related to this patch? Per-patch changelog is supposed to
have only per-patch changes.

...

>  .../bindings/sound/cml,cmx655d.yaml           | 62 +++++++++++++++++++
>  .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
>  MAINTAINERS                                   |  7 +++
>  3 files changed, 71 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/cml,cmx655d.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/cml,cmx655d.yaml b/Documentation/devicetree/bindings/sound/cml,cmx655d.yaml
> new file mode 100644
> index 000000000000..577e1d4942c6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/cml,cmx655d.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/cml,cmx655d.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: CML Micro CMX655D codec
> +
> +maintainers:
> +  - Richard Walton <rwalton@...micro.com>

Some ack on taking maintainer duties would be useful.

> +  - Nikola Jelic <nikola.jelic83@...il.com>
> +
> +description:
> +  The CMX655D is an ultra-low power voice codec.
> +
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: cml,cmx655d
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#sound-dai-cells":
> +    const: 0
> +
> +  reset-gpios:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  interrupt-names:
> +    const: cmx-irq

The name equal to device name is not really usefull. Drop
interrupt-names from binding and DTS.

> +
> +required:
> +  - compatible
> +  - reg
> +  - '#sound-dai-cells'
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/gpio/gpio.h>
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        audio-codec@54 {
> +            compatible = "cml,cmx655d";
> +            reg = <0x54>;
> +            #sound-dai-cells = <0>;
> +            reset-gpios = <&gpio 24 GPIO_ACTIVE_LOW>;
> +            interrupt-parent = <&gpio>;
> +            interrupts = <25 IRQ_TYPE_EDGE_RISING>;
> +        };
> +

Drop stray blank line.


Best regards,
Krzysztof