linux-kernel - Re: [PATCH 2/3] ASoC: codec: wcd938x: Convert to GPIO descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-ER6elHDYtIY0ap@hovoldconsulting.com>
Date: Mon, 24 Mar 2025 09:03:53 +0100
From: Johan Hovold <johan@...nel.org>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Peng Fan <peng.fan@....com>, Steev Klimaszewski <steev@...i.org>,
	"Peng Fan (OSS)" <peng.fan@....nxp.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, Bartosz Golaszewski <brgl@...ev.pl>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	"linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH 2/3] ASoC: codec: wcd938x: Convert to GPIO descriptors

On Mon, Mar 24, 2025 at 08:46:07AM +0100, Linus Walleij wrote:
> On Mon, Mar 24, 2025 at 8:33 AM Peng Fan <peng.fan@....com> wrote:
> 
> > > With this patchset applied, the wcd938x codec used in the Thinkpad
> > > X13s stops working:
> > >
> > > wcd938x_codec audio-codec: soundwire device init timeout
> > > wcd938x_codec audio-codec: ASoC: error at
> > > snd_soc_component_probe on
> > > audio-codec: -110
> > > snd-sc8280xp sound: ASoC: failed to instantiate card -110 snd-
> > > sc8280xp sound: probe with driver snd-sc8280xp failed with error -110
> >
> > Thanks for help testing. But per current in-tree DTS, the reset is using
> > GPIO_ACTIVE_LOW, so it should work.
> >
> > I am not sure whether you are using firmware published DTS,
> > if yes, could you please help check the codec node to dump
> > the reset-gpios property under /sys/firmware/devicetree/xx ?
> 
> I'm also a bit puzzled.
> 
> I think maybe this device has some DTB that comes from the vendor
> with the wrong polarity :/
> 
> If this is the case we need to add a quirk to gpiolib to force this
> GPIO into active low,  something like this:

I'm quite sure Steev is using the mainline devicetree with correct
polarity so that should not be the issue here.

Johan