linux-kernel - RE: [EXTERNAL] [PATCH net-next] octeontx2-af: mcs: Remove redundant 'flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <CH0PR18MB4339D4D8F38B3A70909B9329CDA42@CH0PR18MB4339.namprd18.prod.outlook.com>
Date: Mon, 24 Mar 2025 08:31:41 +0000
From: Geethasowjanya Akula <gakula@...vell.com>
To: Chen Ni <nichen@...as.ac.cn>,
        Sunil Kovvuri Goutham
	<sgoutham@...vell.com>,
        Linu Cherian <lcherian@...vell.com>, Jerin Jacob
	<jerinj@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        Subbaraya
 Sundeep Bhatta <sbhatta@...vell.com>,
        "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org"
	<kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXTERNAL] [PATCH net-next] octeontx2-af: mcs: Remove redundant
 'flush_workqueue()' calls



>-----Original Message-----
>From: Chen Ni <nichen@...as.ac.cn>
>Sent: Monday, March 24, 2025 1:39 PM
>To: Sunil Kovvuri Goutham <sgoutham@...vell.com>; Linu Cherian
><lcherian@...vell.com>; Geethasowjanya Akula <gakula@...vell.com>; Jerin
>Jacob <jerinj@...vell.com>; Hariprasad Kelam <hkelam@...vell.com>;
>Subbaraya Sundeep Bhatta <sbhatta@...vell.com>; andrew+netdev@...n.ch;
>davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
>pabeni@...hat.com
>Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Chen Ni
><nichen@...as.ac.cn>
>Subject: [EXTERNAL] [PATCH net-next] octeontx2-af: mcs: Remove redundant
>'flush_workqueue()' calls
>
>'destroy_workqueue()' already drains the queue before destroying it, so there is
>no need to flush it explicitly.
>
>Remove the redundant 'flush_workqueue()' calls.
>
>This was generated with coccinelle:
>
>@@
>expression E;
>@@
>
>- flush_workqueue(E);
>  destroy_workqueue(E);
>
>Signed-off-by: Chen Ni <nichen@...as.ac.cn>
>---
> drivers/net/ethernet/marvell/octeontx2/af/mcs_rvu_if.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/marvell/octeontx2/af/mcs_rvu_if.c
>b/drivers/net/ethernet/marvell/octeontx2/af/mcs_rvu_if.c
>index d39d86e694cc..655dd4726d36 100644
>--- a/drivers/net/ethernet/marvell/octeontx2/af/mcs_rvu_if.c
>+++ b/drivers/net/ethernet/marvell/octeontx2/af/mcs_rvu_if.c
>@@ -925,7 +925,6 @@ void rvu_mcs_exit(struct rvu *rvu)
> 	if (!rvu->mcs_intr_wq)
> 		return;
>
>-	flush_workqueue(rvu->mcs_intr_wq);
> 	destroy_workqueue(rvu->mcs_intr_wq);
> 	rvu->mcs_intr_wq = NULL;
> }
>--
>2.25.1
Thanks for the fix.
Reviewed-by: Geetha sowjanya <gakula@...vell.com>