linux-kernel - Re: [Intel-wired-lan] [PATCH iwl-next v4] net: e1000e: convert to ndo_hwtstamp_get() and ndo_hwtstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a04a6a77-a00a-b274-972d-51b8ab5b1fe6@intel.com>
Date: Mon, 24 Mar 2025 10:35:56 +0200
From: Avigail Dahan <Avigailx.dahan@...el.com>
To: Piotr Wejman <wejmanpm@...il.com>, Tony Nguyen
	<anthony.l.nguyen@...el.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>, <intel-wired-lan@...ts.osuosl.org>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC: Vadim Fedorenko <vadim.fedorenko@...ux.dev>, Simon Horman
	<horms@...nel.org>, Vitaly Lifshits <vitaly.lifshits@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4] net: e1000e: convert to
 ndo_hwtstamp_get() and ndo_hwtstamp_set()



On 22/02/2025 14:46, Piotr Wejman wrote:
> Update the driver to use the new hardware timestamping API added in commit
> 66f7223039c0 ("net: add NDOs for configuring hardware timestamping").
> Use Netlink extack for error reporting in e1000e_config_hwtstamp.
> Align the indentation of net_device_ops.
> 
> Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Reviewed-by: Vitaly Lifshits <vitaly.lifshits@...el.com>
> Signed-off-by: Piotr Wejman <wejmanpm@...il.com>
> ---
> Changes in v4:
>    - fix line wrappnig
>    - Linke to v3: https://lore.kernel.org/netdev/20250216155729.63862-1-wejmanpm@gmail.com/
> 
> Changes in v3:
>    - remove new lines at the end of the extack
>    - add error print in e1000e_systim_reset
>    - Link to v2: https://lore.kernel.org/netdev/20250208154350.75316-1-wejmanpm@gmail.com/
> 
> Changes in v2:
>    - amend commit message
>    - use extack for error reporting
>    - rename e1000_mii_ioctl to e1000_ioctl
>    - Link to v1: https://lore.kernel.org/netdev/20250202170839.47375-1-piotrwejman90@gmail.com/
> 
>   drivers/net/ethernet/intel/e1000e/e1000.h  |  2 +-
>   drivers/net/ethernet/intel/e1000e/netdev.c | 75 +++++++++++-----------
>   2 files changed, 38 insertions(+), 39 deletions(-)
> 
Tested-by: Avigail Dahan <avigailx.dahan@...el.com>