linux-kernel - RE: [PATCH v2 1/2] dt-bindings: regulator: add adi,adp5055-regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PH0PR03MB6351789B0AA5464755D98049F1A42@PH0PR03MB6351.namprd03.prod.outlook.com>
Date: Mon, 24 Mar 2025 08:45:02 +0000
From: "Torreno, Alexis Czezar" <AlexisCzezar.Torreno@...log.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
CC: Conor Dooley <conor+dt@...nel.org>, Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>
Subject: RE: [PATCH v2 1/2] dt-bindings: regulator: add adi,adp5055-regulator



> -----Original Message-----
> From: Rob Herring (Arm) <robh@...nel.org>
> Sent: Thursday, March 20, 2025 4:29 PM
> To: Torreno, Alexis Czezar <AlexisCzezar.Torreno@...log.com>
> Cc: Conor Dooley <conor+dt@...nel.org>; Liam Girdwood
> <lgirdwood@...il.com>; Mark Brown <broonie@...nel.org>; linux-
> kernel@...r.kernel.org; devicetree@...r.kernel.org; Krzysztof Kozlowski
> <krzk+dt@...nel.org>
> Subject: Re: [PATCH v2 1/2] dt-bindings: regulator: add adi,adp5055-regulator
> 
> [External]
> 
> 
> On Thu, 20 Mar 2025 14:53:54 +0800, Alexis Czezar Torreno wrote:
> > Add documentation for devicetree bindings for ADP5055. The device
> > consists of 3 buck regulators able to connect to high input voltages
> > of up to 18V with no preregulators.
> >
> > Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@...log.com>
> > ---
> >  .../bindings/regulator/adi,adp5055-regulator.yaml  | 161
> +++++++++++++++++++++
> >  MAINTAINERS                                        |   6 +
> >  2 files changed, 167 insertions(+)
> >
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/regulator/adi,adp5055-
> regulator.example.dtb: regulator@70: Unevaluated properties are not allowed
> ('DCDC0', 'DCDC1', 'DCDC2' were unexpected)
> 	from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/schemas/regulator/adi,a
> dp5055-regulator.yaml*__;Iw!!A3Ni8CS0y2Y!-eWjN-
> 2w2f0uPtkfb4hH9s1tlnXrqAvjBw2iVUyg3gsI8gIu9obk0WNxRA7iCvmTTlULk
> GGpQ6ttxWc2VwPf4A$
> 
> doc reference errors (make refcheckdocs):
> 
> See
> https://urldefense.com/v3/__https://patchwork.ozlabs.org/project/devicetr
> ee-bindings/patch/20250320-upstream-adp5055-v2-1-
> aac2d3705802@...log.com__;!!A3Ni8CS0y2Y!-eWjN-
> 2w2f0uPtkfb4hH9s1tlnXrqAvjBw2iVUyg3gsI8gIu9obk0WNxRA7iCvmTTlULk
> GGpQ6ttxWfHZ27Z4w$
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above error(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your
> schema.

My fault, it seems that I really forgot to run 'make dt_binding_check' for v2. I only
ran b4 prep --check (for checkpatch.pl) before I submitted.

Will resubmit after I apply the reviews from the other maintainers.

Thank you for the suggestion on yamllint and dtschema, will add this in our docs.