linux-kernel - Re: [PATCH] mm/vmalloc: fix mischeck pfn valid in vmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <752e606b-640d-46d1-a8e0-fa714b29a7b6@vivo.com>
Date: Mon, 24 Mar 2025 10:13:03 +0800
From: Huan Yang <link@...o.com>
To: Hillf Danton <hdanton@...a.com>, Christoph Hellwig <hch@....de>
Cc: bingbu.cao@...ux.intel.com, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org, opensource.kernel@...o.com, urezki@...il.com,
 vivek.kasireddy@...el.com
Subject: Re: [PATCH] mm/vmalloc: fix mischeck pfn valid in vmap_pfns

HI Hillf,

Thanks fo your suggestion.

在 2025/3/19 19:26, Hillf Danton 写道:
> On Wed, 19 Mar 2025 09:08:51 +0100 Christoph Hellwig wrote:
>> On Wed, Mar 19, 2025 at 01:03:55PM +0800, Hillf Danton wrote:
>>> A quick fix is to add a vmap_pfn variant to walk around the pfn
>>> check in question, like the following diff (just for idea show).
>> No.
>>
> Patient to see your fix, given no low hanging peach left for Mr Folio
> in case of HVO, (feel free to ignore, who is likely about 2.6-mile
> less tough than you could be).

I now believe there are two way to resolve the HVO folio can't vmap in udmabuf.

1. simple copy vmap_pfn code, don't bother common vmap_pfn, use by itself and remove pfn_valid check.

2. implement folio array based vmap(vmap_folios), which can given a range of each folio(offset, nr_pages), so can suit HVO folio's vmap.

1 is simple and can fast fix this issue, but may not too good. I need discuss with bot Christoph and udmabuf's maintainer.

2 is hard, but may worth to research, which I also will try to do. :)