linux-kernel - Re: [PATCH net-next v11 09/10] selftest: tap: Add tests for virtio-net ioctls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250324033129.0016abc9@kernel.org>
Date: Mon, 24 Mar 2025 03:31:29 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Akihiko Odaki <akihiko.odaki@...nix.com>
Cc: Jonathan Corbet <corbet@....net>, Willem de Bruijn
 <willemdebruijn.kernel@...il.com>, Jason Wang <jasowang@...hat.com>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, "Michael S. Tsirkin" <mst@...hat.com>, Xuan Zhuo
 <xuanzhuo@...ux.alibaba.com>, Shuah Khan <shuah@...nel.org>,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, kvm@...r.kernel.org,
 virtualization@...ts.linux-foundation.org, linux-kselftest@...r.kernel.org,
 Yuri Benditovich <yuri.benditovich@...nix.com>, Andrew Melnychenko
 <andrew@...nix.com>, Stephen Hemminger <stephen@...workplumber.org>,
 gur.stavi@...wei.com, Lei Yang <leiyang@...hat.com>, Simon Horman
 <horms@...nel.org>
Subject: Re: [PATCH net-next v11 09/10] selftest: tap: Add tests for
 virtio-net ioctls

On Mon, 17 Mar 2025 19:57:59 +0900 Akihiko Odaki wrote:
> +TEST_F(tap, test_vnetbe)
> +{
> +	int be = 1;
> +	int ret;
> +
> +	ASSERT_FALSE(dev_delete(param_dev_tap_name));
> +	self->deleted = true;
> +
> +	ret = ioctl(self->fd, TUNSETVNETBE, &be);
> +	if (ret == -1 && errno == EINVAL)
> +		SKIP(return, "TUNSETVNETBE not supported");
> +
> +	ASSERT_FALSE(ret);
> +	be = 0;
> +	ASSERT_FALSE(ioctl(self->fd, TUNGETVNETBE, &be));
> +	EXPECT_EQ(1, be);

The config options needed by selftests should be listed in the relevant
config file, I think you need this snippet:

diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config
index 130d532b7e67..9b6aa8c4e6d8 100644
--- a/tools/testing/selftests/net/config
+++ b/tools/testing/selftests/net/config
@@ -101,6 +101,7 @@ CONFIG_IPV6_IOAM6_LWTUNNEL=y
 CONFIG_CRYPTO_SM4_GENERIC=y
 CONFIG_AMT=m
 CONFIG_TUN=y
+CONFIG_TUN_VNET_CROSS_LE=y
 CONFIG_VXLAN=m
 CONFIG_IP_SCTP=m
 CONFIG_NETFILTER_XT_MATCH_POLICY=m
-- 
pw-bot: cr