linux-kernel - Re: [PATCH RFC] ufs: delegate the interrupt service routine to a threaded irq handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e9f33f59-da1f-426b-8bdd-3c47397abf29@acm.org>
Date: Mon, 24 Mar 2025 07:02:25 -0400
From: Bart Van Assche <bvanassche@....org>
To: neil.armstrong@...aro.org, Alim Akhtar <alim.akhtar@...sung.com>,
 Avri Altman <avri.altman@....com>,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 linux-arm-msm@...r.kernel.org, linux-scsi@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] ufs: delegate the interrupt service routine to a
 threaded irq handler

On 3/24/25 5:31 AM, Neil Armstrong wrote:
> On 21/03/2025 17:20, Bart Van Assche wrote:
>> - Instead of retaining hba->ufs_stats.last_intr_status and
>>    hba->ufs_stats.last_intr_ts, please remove both members and also
>>    the debug code that reports the values of these member variables.
>>    Please also remove hba->intr_en.
> 
> Hmm ok so no need for the IRQ debug code anymore ? I guess this should
> be in a separate cleanup patch.

Hi Neil,

There are two reasons why I propose to remove that code:
- I don't think that it is possible to keep that code and switch to
   threaded interrupts without a measurable negative performance impact.
- That debug code is primarily useful for hardware (SoC) debugging,
   something that falls outside the scope of the UFS driver.

Thanks,

Bart.