linux-kernel - Re: [PATCH] perf: annotate asm_pure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250324113445.GA604566@e132581.arm.com>
Date: Mon, 24 Mar 2025 11:34:45 +0000
From: Leo Yan <leo.yan@....com>
To: Marcus Meissner <meissner@...e.de>
Cc: peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
	namhyung@...nel.org, mark.rutland@....com,
	alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
	irogers@...gle.com, adrian.hunter@...el.com,
	kan.liang@...ux.intel.com, carsten.haitzler@....com,
	james.clark@...aro.org, linux-perf-users@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf: annotate asm_pure_loop.S

On Sun, Mar 23, 2025 at 09:53:45AM +0100, Marcus Meissner wrote:
> Annotate so it is built with non-executable stack.
> 
> Fixes: 8b97519711c3a0f9eb8274a227dff3fe4f0f72a2

Fixes: 8b97519711c3 ("perf test: Add asm pureloop test tool")

> Signed-off-by: Marcus Meissner <meissner@...e.de>
> ---
>  tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S b/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S
> index 75cf084a927d..577760046772 100644
> --- a/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S
> +++ b/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S
> @@ -26,3 +26,5 @@ skip:
>  	mov	x0, #0
>  	mov	x8, #93 // __NR_exit syscall
>  	svc	#0
> +
> +.section .note.GNU-stack, "", @progbits

With the fix tag change:

Reviewed-by: Leo Yan <leo.yan@....com>

I found actually Jan Stancek has submitted a similiar patch [1]
~2 years ago but we missed, sorry for that.

[1] https://lore.kernel.org/linux-perf-users/e79288922fbd0bad6facf06488735ec74f811d1b.1689588798.git.jstancek@redhat.com/