linux-kernel - [PATCH v2 0/3] ASoC: codec: wcd93xx: Convert to GPIO descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250324-wcd-gpiod-v2-0-773f67ce3b56@nxp.com>
Date: Mon, 24 Mar 2025 19:51:26 +0800
From: "Peng Fan (OSS)" <peng.fan@....nxp.com>
To: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, 
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, 
 Linus Walleij <linus.walleij@...aro.org>, 
 Bartosz Golaszewski <brgl@...ev.pl>, 
 Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, 
 Steev Klimaszewski <steev@...i.org>, Johan Hovold <johan@...nel.org>
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org, 
 linux-gpio@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
 Peng Fan <peng.fan@....com>
Subject: [PATCH v2 0/3] ASoC: codec: wcd93xx: Convert to GPIO descriptors

Steev,
 I would appreciate if you have time to help test again.
 Hope V2 could work on your platform.

Linus,
 Since v2 is only a minor change to use GPIOD_OUT_LOW to replace
 GPIOD_ASIS when devm_gpio_get, so I still keep you R-b. Appreciate
 for your quick action.

Johan,
 Thanks for help look into V1. Appreciate if you have time to look
 into v2.

Sorry for this quick V2, there is no rush, but just wanna to avoid sending
this out in coming merge window.

of_gpio.h is deprecated, so update driver to use gpiod API.

The current driver use value 0 to assert reset and 1 to deassert reset.
The DTSes in tree that use the codec are using GPIO_ACTIVE_LOW.
So it is safe to use devm_gpiod_get to get GPIO descriptors and
use gpiod_set_value to configure output with value 1 means raw value
0, value 0 means raw value 1.

Note:
I not have devices to test, just my best pratice to do the convertion.

Signed-off-by: Peng Fan <peng.fan@....com>
---
Changes in v2:
- Use GPIOD_OUT_LOW to replace GPIOD_ASIS to configure direction.
- Update commit log with "in-tree DTS files have the right polarity set up
  already so we can expect this to "just work"".
- Link to v1: https://lore.kernel.org/r/20250324-wcd-gpiod-v1-0-27afa472e331@nxp.com

---
Peng Fan (3):
      ASoC: codec: wcd939x: Convert to GPIO descriptors
      ASoC: codec: wcd938x: Convert to GPIO descriptors
      ASoC: codec: wcd9335: Convert to GPIO descriptors

 sound/soc/codecs/wcd9335.c | 15 +++++++--------
 sound/soc/codecs/wcd938x.c | 13 ++++++-------
 sound/soc/codecs/wcd939x.c | 16 ++++++++--------
 3 files changed, 21 insertions(+), 23 deletions(-)
---
base-commit: 9388ec571cb1adba59d1cded2300eeb11827679c
change-id: 20250324-wcd-gpiod-782c4a0d8688

Best regards,
-- 
Peng Fan <peng.fan@....com>