[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <113a789f-54e8-4d42-b260-829c194758a7@pereznus.es>
Date: Mon, 24 Mar 2025 12:58:14 +0100
From: Sergio PĆ©rez <sergio@...eznus.es>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Tomasz Duszynski <tduszyns@...il.com>, Jonathan Cameron
<jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, linux-iio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/2] dt-bindings: iio: light: bh1750: Add reset-gpios
property
El 24/03/2025 a las 9:08, Krzysztof Kozlowski escribiĆ³:
> On Fri, Mar 21, 2025 at 05:16:08PM +0100, Sergio Perez wrote:
>> + reset-gpios:
>> + description: GPIO connected to the DVI reset pin (active low)
>> + maxItems: 1
>> +
>> required:
>> - compatible
>> - reg
>> @@ -36,9 +40,12 @@ examples:
>> #address-cells = <1>;
>> #size-cells = <0>;
>>
>> + #include <dt-bindings/gpio/gpio.h>
> This goes upper. Please open any other bindings to see how it is done.
>
> With fixed placement:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Thanks, I will fix the placement of include and send new version (v6).
> ---
>
> <form letter>
> This is an automated instruction, just in case, because many review tags
> are being ignored. If you know the process, you can skip it (please do
> not feel offended by me posting it here - no bad intentions intended).
> If you do not know the process, here is a short explanation:
>
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions of patchset, under or above your Signed-off-by tag, unless
> patch changed significantly (e.g. new properties added to the DT
> bindings). Tag is "received", when provided in a message replied to you
> on the mailing list. Tools like b4 can help here. However, there's no
> need to repost patches *only* to add the tags. The upstream maintainer
> will do that for tags received on the version they apply.
>
> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
> </form letter>
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists